Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: test/cctest/compiler/test-run-jsexceptions.cc

Issue 1022463003: [turbofan] Remove stale TODO from FunctionTester. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Back out one cleanup. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/function-tester.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-run-jsexceptions.cc
diff --git a/test/cctest/compiler/test-run-jsexceptions.cc b/test/cctest/compiler/test-run-jsexceptions.cc
index 9b31fe09be15837c4b6df313437eb0a4f5b9f45f..272311adb9b81faadec3a279201a431d5b8ed363 100644
--- a/test/cctest/compiler/test-run-jsexceptions.cc
+++ b/test/cctest/compiler/test-run-jsexceptions.cc
@@ -31,17 +31,14 @@ TEST(ThrowMessagePosition) {
v8::Handle<v8::Message> message;
message = T.CheckThrowsReturnMessage(T.Val(1), T.undefined());
- CHECK(!message.IsEmpty());
CHECK_EQ(2, message->GetLineNumber());
CHECK_EQ(40, message->GetStartPosition());
message = T.CheckThrowsReturnMessage(T.Val(2), T.undefined());
- CHECK(!message.IsEmpty());
CHECK_EQ(3, message->GetLineNumber());
CHECK_EQ(67, message->GetStartPosition());
message = T.CheckThrowsReturnMessage(T.Val(3), T.undefined());
- CHECK(!message.IsEmpty());
CHECK_EQ(4, message->GetLineNumber());
CHECK_EQ(95, message->GetStartPosition());
}
@@ -57,11 +54,9 @@ TEST(ThrowMessageDirectly) {
v8::Handle<v8::Message> message;
message = T.CheckThrowsReturnMessage(T.false_value(), T.Val("Wat?"));
- CHECK(!message.IsEmpty());
CHECK(message->Get()->Equals(v8_str("Uncaught Error: Wat?")));
message = T.CheckThrowsReturnMessage(T.true_value(), T.Val("Kaboom!"));
- CHECK(!message.IsEmpty());
CHECK(message->Get()->Equals(v8_str("Uncaught Kaboom!")));
}
@@ -80,11 +75,9 @@ TEST(ThrowMessageIndirectly) {
v8::Handle<v8::Message> message;
message = T.CheckThrowsReturnMessage(T.false_value(), T.Val("Wat?"));
- CHECK(!message.IsEmpty());
CHECK(message->Get()->Equals(v8_str("Uncaught Error: Wat?")));
message = T.CheckThrowsReturnMessage(T.true_value(), T.Val("Kaboom!"));
- CHECK(!message.IsEmpty());
CHECK(message->Get()->Equals(v8_str("Uncaught Kaboom!")));
}
« no previous file with comments | « test/cctest/compiler/function-tester.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698