Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1022463003: [turbofan] Remove stale TODO from FunctionTester. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove stale TODO from FunctionTester. R=titzer@chromium.org TEST=cctest/test-run-jsexceptions Committed: https://crrev.com/addca7072549d790f1e6862be08937880bddbef5 Cr-Commit-Position: refs/heads/master@{#27300}

Patch Set 1 #

Patch Set 2 : Back out one cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M test/cctest/compiler/function-tester.h View 2 chunks +1 line, -4 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-18 14:45:25 UTC) #1
titzer
lgtm
5 years, 9 months ago (2015-03-18 15:35:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022463003/20001
5 years, 9 months ago (2015-03-19 10:33:48 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 12:40:55 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 12:41:13 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/addca7072549d790f1e6862be08937880bddbef5
Cr-Commit-Position: refs/heads/master@{#27300}

Powered by Google App Engine
This is Rietveld 408576698