Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1022463002: [iOS] Upstream files in //ios/chrome/browser/autofill (Closed)

Created:
5 years, 9 months ago by droger
Modified:
5 years, 9 months ago
Reviewers:
dconnelly, Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, gcasto+watchlist_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream files in //ios/chrome/browser/autofill BUG=437508 Committed: https://crrev.com/69b5fc8fc036b5ade5e1498d368ef5c49fb74e48 Cr-Commit-Position: refs/heads/master@{#321805}

Patch Set 1 : Rebase #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2350 lines, -2 lines) Patch
M ios/chrome/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/autofill/autofill_agent_utils.h View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/autofill_agent_utils.mm View 1 chunk +139 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_input_accessory_view.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_input_accessory_view.mm View 1 chunk +371 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_input_accessory_view_controller.h View 1 chunk +95 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_input_accessory_view_controller.mm View 1 chunk +507 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_input_accessory_view_delegate.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_suggestion_controller.h View 1 chunk +60 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_suggestion_controller.mm View 1 chunk +352 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_suggestion_label.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_suggestion_label.mm View 1 chunk +238 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_suggestion_provider.h View 1 chunk +55 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_suggestion_view.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_suggestion_view.mm View 1 chunk +97 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/form_suggestion_view_client.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/browser/passwords/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/passwords/password_generation_utils.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/passwords/password_generation_utils.mm View 1 chunk +50 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 3 chunks +19 lines, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/public/test/test_web_state.h View 3 chunks +17 lines, -0 lines 0 comments Download
M ios/web/public/test/test_web_state.cc View 3 chunks +43 lines, -1 line 0 comments Download
A ios/web/public/web_state/crw_web_view_proxy.h View 1 chunk +52 lines, -0 lines 0 comments Download
M ios/web/public/web_state/web_state.h View 1 5 chunks +49 lines, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
droger
5 years, 9 months ago (2015-03-23 13:12:55 UTC) #6
dconnelly
lgtm
5 years, 9 months ago (2015-03-23 13:27:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022463002/100001
5 years, 9 months ago (2015-03-23 14:27:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51296)
5 years, 9 months ago (2015-03-23 14:34:38 UTC) #11
droger
+estade for the new dependency on components/autofill/core/browser in ios/chrome/DEPS
5 years, 9 months ago (2015-03-23 15:31:23 UTC) #13
Evan Stade
lgtm
5 years, 9 months ago (2015-03-23 17:45:55 UTC) #14
droger
Thanks for the reviews.
5 years, 9 months ago (2015-03-23 17:46:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022463002/100001
5 years, 9 months ago (2015-03-23 17:46:55 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years, 9 months ago (2015-03-23 17:51:23 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 17:52:09 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/69b5fc8fc036b5ade5e1498d368ef5c49fb74e48
Cr-Commit-Position: refs/heads/master@{#321805}

Powered by Google App Engine
This is Rietveld 408576698