Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1022443002: Remove unused shutdown() function from WebSchedulerImpl. (Closed)

Created:
5 years, 9 months ago by rmcilroy
Modified:
5 years, 9 months ago
Reviewers:
jamesr, Sami
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused shutdown() function from WebSchedulerImpl. Removes the unused shutdown() function from WebSchedulerImpl now that it is no longer used by Blink. BUG=467369 Committed: https://crrev.com/0d3caa98e164dca3ba17c0ff9330359ad8af3074 Cr-Commit-Position: refs/heads/master@{#321410}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/renderer/scheduler/web_scheduler_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/scheduler/web_scheduler_impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/webscheduler_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/html_viewer/webscheduler_impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
rmcilroy
jamesr: please take a look at mojo/ skyostil: please take a look at content/renderer/scheduler/ Thanks.
5 years, 9 months ago (2015-03-18 12:51:16 UTC) #2
Sami
Yay, lgtm.
5 years, 9 months ago (2015-03-18 15:48:13 UTC) #3
jamesr
mojo/ lgtm
5 years, 9 months ago (2015-03-18 16:14:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022443002/1
5 years, 9 months ago (2015-03-18 16:20:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/6499) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-18 16:23:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022443002/20001
5 years, 9 months ago (2015-03-19 18:37:01 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 19:38:11 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 19:39:38 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d3caa98e164dca3ba17c0ff9330359ad8af3074
Cr-Commit-Position: refs/heads/master@{#321410}

Powered by Google App Engine
This is Rietveld 408576698