Move the worker script loading code to the worker process (phase:1/5)

Move the worker script loading code to the worker process (phase:1/5)

- Add contentSecurityPolicy and WebContentSecurityPolicyType to the arguments of WebSharedWorkerRepositoryClient::createSharedWorkerConnector.
- Add workerScriptLoaded(), workerScriptLoadFailed(), and selectAppChacheID() to WebSharedWorkerClient.

This is step 1 of moving the worker script loading code from the renderer process to the worker process.
See: http://crbug.com/329786

BUG=329786
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164576

[horo, 2013-12-19 06:55:26]

kinuko@
Could you please review this?

[kinuko, 2013-12-20 05:07:12]

lgtm, but please fix the typo :)

https://codereview.chromium.org/102243010/diff/1/Source/web/SharedWorkerRepos...
File Source/web/SharedWorkerRepositoryClientImpl.cpp (right):

https://codereview.chromium.org/102243010/diff/1/Source/web/SharedWorkerRepos...
Source/web/SharedWorkerRepositoryClientImpl.cpp:162:
OwnPtr<WebSharedWorkerConnector> webWorkerConnector =
adoptPtr(m_client->createSharedWorkerConnector(url, name, getId(document),
worker->executionContext()->contentSecurityPolicy()->deprecatedHeader(),
static_cast<blink::WebContentSecurityPolicyType>(worker->executionContext()->contentSecurityPolicy()->deprecatedHeaderType())));
It's a bit suspected that we really need to send this to SharedWorker, though
without this some test fails..

https://codereview.chromium.org/102243010/diff/1/public/web/WebSharedWorkerCl...
File public/web/WebSharedWorkerClient.h (right):

https://codereview.chromium.org/102243010/diff/1/public/web/WebSharedWorkerCl...
public/web/WebSharedWorkerClient.h:73: virtual void selectAppChacheID(long long
appCacheID) { }
Chache -> Cache

:)

[horo, 2013-12-20 06:30:24]

https://codereview.chromium.org/102243010/diff/1/Source/web/SharedWorkerRepos...
File Source/web/SharedWorkerRepositoryClientImpl.cpp (right):

https://codereview.chromium.org/102243010/diff/1/Source/web/SharedWorkerRepos...
Source/web/SharedWorkerRepositoryClientImpl.cpp:162:
OwnPtr<WebSharedWorkerConnector> webWorkerConnector =
adoptPtr(m_client->createSharedWorkerConnector(url, name, getId(document),
worker->executionContext()->contentSecurityPolicy()->deprecatedHeader(),
static_cast<blink::WebContentSecurityPolicyType>(worker->executionContext()->contentSecurityPolicy()->deprecatedHeaderType())));
On 2013/12/20 05:07:12, kinuko wrote:
> It's a bit suspected that we really need to send this to SharedWorker, though
> without this some test fails..

In the current source code these content security policy and type are used in
SharedWorkerGlobalScope.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
So I think we should send them, not to change the behaviour in
SharedWorkerGlobalScope now.

https://codereview.chromium.org/102243010/diff/1/public/web/WebSharedWorkerCl...
File public/web/WebSharedWorkerClient.h (right):

https://codereview.chromium.org/102243010/diff/1/public/web/WebSharedWorkerCl...
public/web/WebSharedWorkerClient.h:73: virtual void selectAppChacheID(long long
appCacheID) { }
On 2013/12/20 05:07:12, kinuko wrote:
> Chache -> Cache
> 
> :)

Done.

[kinuko, 2013-12-20 06:43:20]

https://codereview.chromium.org/102243010/diff/1/Source/web/SharedWorkerRepos...
File Source/web/SharedWorkerRepositoryClientImpl.cpp (right):

https://codereview.chromium.org/102243010/diff/1/Source/web/SharedWorkerRepos...
Source/web/SharedWorkerRepositoryClientImpl.cpp:162:
OwnPtr<WebSharedWorkerConnector> webWorkerConnector =
adoptPtr(m_client->createSharedWorkerConnector(url, name, getId(document),
worker->executionContext()->contentSecurityPolicy()->deprecatedHeader(),
static_cast<blink::WebContentSecurityPolicyType>(worker->executionContext()->contentSecurityPolicy()->deprecatedHeaderType())));
On 2013/12/20 06:30:24, horo wrote:
> On 2013/12/20 05:07:12, kinuko wrote:
> > It's a bit suspected that we really need to send this to SharedWorker,
though
> > without this some test fails..
> 
> In the current source code these content security policy and type are used in
> SharedWorkerGlobalScope.
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> So I think we should send them, not to change the behaviour in
> SharedWorkerGlobalScope now.

Right, I wanted to note that this may be changed and we may start using
SharedWorker's own CSP policy when we have new agreement (see:
http://lists.w3.org/Archives/Public/public-webappsec/2013Nov/0008.html)

[horo, 2014-01-06 14:50:36]

jochen@
Could you please review this CL?

Thank you.

[jochen (gone - plz use gerrit), 2014-01-07 10:18:38]

lgtm

[commit-bot: I haz the power, 2014-01-07 10:50:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/horo@chromium.org/102243010/110001

[commit-bot: I haz the power, 2014-01-07 13:09:20]

Change committed as 164576