Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager.js

Issue 1022423005: Move view change analytics tracking into DirectoryModel where implementation details can be hidden. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add FSP extension whitelist so we can report names to analytics rather than extension ids for provi… Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/directory_model.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/file_manager.js
diff --git a/ui/file_manager/file_manager/foreground/js/file_manager.js b/ui/file_manager/file_manager/foreground/js/file_manager.js
index d415a1742135fc46272d9156ff8817021f519308..36a0d3d77df3cb87ca6c77e82b9b3d9a8f6ebefa 100644
--- a/ui/file_manager/file_manager/foreground/js/file_manager.js
+++ b/ui/file_manager/file_manager/foreground/js/file_manager.js
@@ -850,7 +850,8 @@ FileManager.prototype = /** @struct */ {
this.fileFilter_,
this.metadataModel_,
this.volumeManager_,
- this.fileOperationManager_);
+ this.fileOperationManager_,
+ assert(this.tracker_));
this.folderShortcutsModel_ = new FolderShortcutsDataModel(
this.volumeManager_);
@@ -861,19 +862,6 @@ FileManager.prototype = /** @struct */ {
this.selectionHandler_.onFileSelectionChanged.bind(
this.selectionHandler_));
- this.directoryModel_.addEventListener(
- 'directory-changed',
- function(event) {
- if (event.volumeChanged) {
- var volumeInfo =
- this.volumeManager_.getVolumeInfo(event.newDirEntry);
- // NOTE: That dynamic values, like volume name MUST NOT
- // be sent to GA as that value can contain PII.
- // VolumeType is an enum.
- this.tracker_.sendAppView(volumeInfo.volumeType);
- }
- }.bind(this));
-
// TODO(mtomasz, yoshiki): Create navigation list earlier, and here just
// attach the directory model.
this.initDirectoryTree_();
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/directory_model.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698