Issue 1022423002: Make SkCanvas::getBaseLayerSize() virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1022423002: Make SkCanvas::getBaseLayerSize() virtual (Closed)

Created:
5 years, 9 months ago by tomhudson

Modified:
5 years, 9 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Make SkCanvas::getBaseLayerSize() virtual Subclasses of SkCanvas may need to override the behavior here - for example, any proxy or deferred canvas may not know its own size and need to delegate to another object. We'll also work on reducing use of this function (https://skbug.com/3569), but some of the current uses seem to be semantically necessary. R=reed@google.com BUG=skia:3566 Committed: https://skia.googlesource.com/skia/+/68260fa1e913cb1f1f4f07755acd11357a47dc6f

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/core/SkCanvas.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022423002/1

5 years, 9 months ago (2015-03-23 14:17:04 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-23 14:22:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/68260fa1e913cb1f1f4f07755acd11357a47dc6f