Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1022403002: X87: Remove code object from StackHandler. (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove code object from StackHandler. port e0aa8ebf933b4c659e1c4a01ba244c5de452ff1c (r27103). original commit message: This reduces the size of the StackHandler by one word. We no longer need to keep track of the code object, as the stack walk finds it. BUG= R=weiliang.lin@intel.com Committed: https://crrev.com/289ee153072a23f814eb00b96b6eac511dab0041 Cr-Commit-Position: refs/heads/master@{#27353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/x87/macro-assembler-x87.cc View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
chunyang.dai
PTAL.
5 years, 9 months ago (2015-03-23 08:03:06 UTC) #1
chunyang.dai
5 years, 9 months ago (2015-03-23 08:03:25 UTC) #3
Weiliang
lgtm
5 years, 9 months ago (2015-03-23 08:19:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022403002/1
5 years, 9 months ago (2015-03-23 08:19:30 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/289ee153072a23f814eb00b96b6eac511dab0041 Cr-Commit-Position: refs/heads/master@{#27353}
5 years, 9 months ago (2015-03-23 08:27:27 UTC) #7
chunyang.dai
5 years, 9 months ago (2015-03-23 08:27:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
289ee153072a23f814eb00b96b6eac511dab0041 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698