Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 1022363002: ServiceWorker: Run ServiceWorkerContextTest.DeleteAndStartOver on disk (Closed)

Created:
5 years, 9 months ago by nhiroki
Modified:
5 years, 9 months ago
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Run ServiceWorkerContextTest.DeleteAndStartOver on disk Currently DeleteAndStartOver() is tested in memory storage (MemEnv) supported by LevelDB for performance, but it seems preferable to test it on real environment, that is, on disk storage because the recovery process can be affected by characteristics of lower filesystem. BUG=468926 TEST=content_unittests --gtest_filter=ServiceWorkerContextTest.DeleteAndStartOver Committed: https://crrev.com/e47602102bf2c4c32af751e13cf08aab639c3576 Cr-Commit-Position: refs/heads/master@{#322346}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -31 lines) Patch
M content/browser/geofencing/geofencing_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 4 chunks +11 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_request_handler_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
nhiroki
PTAL, thanks!
5 years, 9 months ago (2015-03-23 09:13:27 UTC) #4
michaeln
lgtm
5 years, 9 months ago (2015-03-25 00:47:12 UTC) #5
nhiroki
+mek@, can you review c/b/geofencing/?
5 years, 9 months ago (2015-03-25 03:18:16 UTC) #7
Marijn Kruisselbrink
On 2015/03/25 03:18:16, nhiroki wrote: > +mek@, can you review c/b/geofencing/? c/b/geofencing/ lgtm
5 years, 9 months ago (2015-03-25 16:03:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022363002/40001
5 years, 9 months ago (2015-03-26 09:08:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/51306) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-26 09:12:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022363002/60001
5 years, 9 months ago (2015-03-26 09:29:39 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 9 months ago (2015-03-26 09:58:13 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 09:58:58 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e47602102bf2c4c32af751e13cf08aab639c3576
Cr-Commit-Position: refs/heads/master@{#322346}

Powered by Google App Engine
This is Rietveld 408576698