Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1022333004: [V8] Removed SourceLocationRestrict (Closed)

Created:
5 years, 9 months ago by kozy
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[V8] Removed SourceLocationRestrict This method uses in messages.js in GetSourceLine and GetPositionInLine. This methods uses in v8::Message API methods and there is no documentation about it. Method looks obsolete. One of the strange side effect is shown by attached issue. BUG=chromium:468781 R=yangguo@chromium.org LOG=Y Committed: https://crrev.com/b563ceac0f95551a128a1403cdbacc7aefcdabaf Cr-Commit-Position: refs/heads/master@{#27374}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -142 lines) Patch
M src/messages.js View 4 chunks +0 lines, -54 lines 0 comments Download
M test/mjsunit/debug-sourceinfo.js View 1 2 2 chunks +3 lines, -88 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
kozy
Yang, please take a look.
5 years, 9 months ago (2015-03-23 10:22:56 UTC) #1
Yang
On 2015/03/23 10:22:56, kozyatinskiy wrote: > Yang, please take a look. lgtm.
5 years, 9 months ago (2015-03-23 10:31:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022333004/20001
5 years, 9 months ago (2015-03-23 14:59:57 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4116)
5 years, 9 months ago (2015-03-23 15:01:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022333004/40001
5 years, 9 months ago (2015-03-23 15:21:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1451)
5 years, 9 months ago (2015-03-23 15:24:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022333004/40001
5 years, 9 months ago (2015-03-23 16:32:56 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-23 16:33:06 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/b563ceac0f95551a128a1403cdbacc7aefcdabaf Cr-Commit-Position: refs/heads/master@{#27374}
5 years, 9 months ago (2015-03-23 16:33:26 UTC) #15
Michael Achenbach
5 years, 9 months ago (2015-03-24 12:04:19 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1028413002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] This seems to change layout test
expectations of some tests, e.g.:
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg...

Expectation example:
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_6...

Please add a needsmanualrebaseline expectation to the tests affected by this
change on the blink side first before relanding..

Powered by Google App Engine
This is Rietveld 408576698