Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/browser/about_flags.cc

Issue 1022333002: Initial CL for Data Saver (Flywheel) prompt when cellular network detected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add command line flags to histograms.xml Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/preferences.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index ad25f94f100da7e064a1a05e38671da5c4604d9d..1e64b8341cf386845831d6d352ba2b03b02ad057 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -425,6 +425,19 @@ const Experiment::Choice kAshScreenRotationAnimationChoices[] = {
};
#endif
+#if defined(OS_CHROMEOS)
+const Experiment::Choice kDataSaverPromptChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
+ chromeos::switches::kDisableDataSaverPrompt, "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
+ chromeos::switches::kEnableDataSaverPrompt, "" },
+ { IDS_FLAGS_DATASAVER_PROMPT_DEMO_MODE,
+ chromeos::switches::kEnableDataSaverPrompt,
+ chromeos::switches::kDataSaverPromptDemoMode },
+};
+#endif
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the experiment is the internal name. If you'd like to
@@ -2319,6 +2332,15 @@ const Experiment kExperiments[] = {
SINGLE_VALUE_TYPE(chromeos::switches::kEnableMtpWriteSupport)
},
#endif // defined(OS_CHROMEOS)
+#if defined(OS_CHROMEOS)
+ {
+ "enable-datasaver-prompt",
+ IDS_FLAGS_DATASAVER_PROMPT_NAME,
+ IDS_FLAGS_DATASAVER_PROMPT_DESCRIPTION,
+ kOsCrOS,
+ MULTI_VALUE_TYPE(kDataSaverPromptChoices)
+ },
+#endif // defined(OS_CHROMEOS)
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/preferences.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698