Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1022293002: Revert of Python readability review for dbeam@. (Closed)

Created:
5 years, 9 months ago by Nico
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-closure_chromium.org, Tyler Breisacher (Chromium)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(closed, pfeldman did this already) Revert of Python readability review for dbeam@. (patchset #4 id:280001 of https://codereview.chromium.org/476453002/) Reason for revert: Looks like this broke the Linux and Linux 64 clobber bots: http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/433 http://build.chromium.org/p/chromium/builders/Linux/builds/59857 FAILED: cd ../../remoting; python ../third_party/closure_compiler/checker.py --strict --no-single-file --success-stamp ../out/Release/remoting_key_tester_jscompile.stamp tools/javascript_key_tester/background.js tools/javascript_key_tester/chord_tracker.js tools/javascript_key_tester/event_listeners.js tools/javascript_key_tester/main.js webapp/js_proto/chrome_proto.js webapp/js_proto/chrome_event_proto.js (ERROR) Exception in thread "main" java.lang.UnsupportedClassVersionError: org/chromium/closure/compiler/Runner : Unsupported major.minor version 51.0 at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631) at java.lang.ClassLoader.defineClass(ClassLoader.java:615) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141) at java.net.URLClassLoader.defineClass(URLClassLoader.java:283) at java.net.URLClassLoader.access$000(URLClassLoader.java:58) at java.net.URLClassLoader$1.run(URLClassLoader.java:197) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:190) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) Could not find the main class: org.chromium.closure.compiler.Runner. Program will exit. Original issue's description: > Python readability review for dbeam@. > > R=rothwell@google.com > > Committed: https://crrev.com/c5503ce046fdad8c76129c0061f0d6011c2fe92b > Cr-Commit-Position: refs/heads/master@{#321693} TBR=rothwell@google.com,thestig@chromium.org,dbeam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -209 lines) Patch
M third_party/closure_compiler/checker.py View 7 chunks +120 lines, -173 lines 0 comments Download
M third_party/closure_compiler/compile_js.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/closure_compiler/compiler_customization_test.py View 1 chunk +9 lines, -8 lines 0 comments Download
M third_party/closure_compiler/processor.py View 6 chunks +34 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Nico
Created Revert of Python readability review for dbeam@.
5 years, 9 months ago (2015-03-21 21:00:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022293002/1
5 years, 9 months ago (2015-03-21 21:00:44 UTC) #2
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-21 21:01:25 UTC) #4
Dan Beam
pfeldman@ beat you to this: can we close?
5 years, 9 months ago (2015-03-23 19:16:33 UTC) #6
Nico
On 2015/03/23 19:16:33, Dan Beam wrote: > pfeldman@ beat you to this: can we close? ...
5 years, 9 months ago (2015-03-23 19:22:41 UTC) #7
Dan Beam
On 2015/03/23 19:22:41, Nico wrote: > On 2015/03/23 19:16:33, Dan Beam wrote: > > pfeldman@ ...
5 years, 9 months ago (2015-03-23 19:23:13 UTC) #8
Nico
5 years, 9 months ago (2015-03-23 19:24:03 UTC) #9
Message was sent while issue was closed.
Never delete CLs, that breaks links.

On Mon, Mar 23, 2015 at 12:23 PM, <dbeam@chromium.org> wrote:

> On 2015/03/23 19:22:41, Nico wrote:
>
>> On 2015/03/23 19:16:33, Dan Beam wrote:
>> > pfeldman@ beat you to this: can we close?
>>
>
>  Err, sure. (I don't close most of the CLs I don't end up using *shrug*)
>>
>
> or delete?
>
> https://codereview.chromium.org/1022293002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698