Description(closed, pfeldman did this already)
Revert of Python readability review for dbeam@. (patchset #4 id:280001 of https://codereview.chromium.org/476453002/)
Reason for revert:
Looks like this broke the Linux and Linux 64 clobber bots:
http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/433
http://build.chromium.org/p/chromium/builders/Linux/builds/59857
FAILED: cd ../../remoting; python ../third_party/closure_compiler/checker.py --strict --no-single-file --success-stamp ../out/Release/remoting_key_tester_jscompile.stamp tools/javascript_key_tester/background.js tools/javascript_key_tester/chord_tracker.js tools/javascript_key_tester/event_listeners.js tools/javascript_key_tester/main.js webapp/js_proto/chrome_proto.js webapp/js_proto/chrome_event_proto.js
(ERROR) Exception in thread "main" java.lang.UnsupportedClassVersionError: org/chromium/closure/compiler/Runner : Unsupported major.minor version 51.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
Could not find the main class: org.chromium.closure.compiler.Runner. Program will exit.
Original issue's description:
> Python readability review for dbeam@.
>
> R=rothwell@google.com
>
> Committed: https://crrev.com/c5503ce046fdad8c76129c0061f0d6011c2fe92b
> Cr-Commit-Position: refs/heads/master@{#321693}
TBR=rothwell@google.com,thestig@chromium.org,dbeam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Patch Set 1 #
Created: 5 years, 9 months ago
(Patch set is too large to download)
Messages
Total messages: 9 (2 generated)
|