Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Side by Side Diff: LayoutTests/fast/events/resources/message-port-multi.js

Issue 1022283002: Throw TypeError if value conversion to transferable fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add more tests for TypeError throwing Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 if (window.testRunner) { 1 if (window.testRunner) {
2 testRunner.dumpAsText(); 2 testRunner.dumpAsText();
3 testRunner.waitUntilDone(); 3 testRunner.waitUntilDone();
4 } 4 }
5 5
6 description("This test checks the various use cases around sending multiple port s through MessagePort.postMessage"); 6 description("This test checks the various use cases around sending multiple port s through MessagePort.postMessage");
7 7
8 var channel = new MessageChannel(); 8 var channel = new MessageChannel();
9 var channel2 = new MessageChannel(); 9 var channel2 = new MessageChannel();
10 var channel3 = new MessageChannel(); 10 var channel3 = new MessageChannel();
11 var channel4 = new MessageChannel(); 11 var channel4 = new MessageChannel();
12 12
13 channel.port1.postMessage("noport"); 13 channel.port1.postMessage("noport");
14 channel.port1.postMessage("zero ports", []); 14 channel.port1.postMessage("zero ports", []);
15 channel.port1.postMessage("two ports", [channel2.port1, channel2.port2]); 15 channel.port1.postMessage("two ports", [channel2.port1, channel2.port2]);
16 16
17 // Now test various failure cases 17 // Now test various failure cases
18 shouldThrow('channel.port1.postMessage("same port", [channel.port1])', '"DataClo neError: Failed to execute \'postMessage\' on \'MessagePort\': Port at index 0 c ontains the source port."'); 18 shouldThrow('channel.port1.postMessage("same port", [channel.port1])', '"DataClo neError: Failed to execute \'postMessage\' on \'MessagePort\': Port at index 0 c ontains the source port."');
19 shouldThrow('channel.port1.postMessage("null port", [channel3.port1, null, chann el3.port2])', '"DataCloneError: Failed to execute \'postMessage\' on \'MessagePo rt\': Value at index 1 is an untransferable \'null\' value."'); 19 shouldThrow('channel.port1.postMessage("null port", [channel3.port1, null, chann el3.port2])', '"TypeError: Failed to execute \'postMessage\' on \'MessagePort\': Value at index 1 is an untransferable \'null\' value."');
20 shouldThrow('channel.port1.postMessage("notAPort", [channel3.port1, {}, channel3 .port2])', '"DataCloneError: Failed to execute \'postMessage\' on \'MessagePort\ ': Value at index 1 does not have a transferable type."'); 20 shouldThrow('channel.port1.postMessage("notAPort", [channel3.port1, {}, channel3 .port2])', '"TypeError: Failed to execute \'postMessage\' on \'MessagePort\': Va lue at index 1 does not have a transferable type."');
21 shouldThrow('channel.port1.postMessage("duplicate port", [channel3.port1, channe l3.port1])', '"DataCloneError: Failed to execute \'postMessage\' on \'MessagePor t\': Message port at index 1 is a duplicate of an earlier port."'); 21 shouldThrow('channel.port1.postMessage("duplicate port", [channel3.port1, channe l3.port1])', '"DataCloneError: Failed to execute \'postMessage\' on \'MessagePor t\': Message port at index 1 is a duplicate of an earlier port."');
22 // Should be OK to send channel3.port1 (should not have been disentangled by the previous failed calls). 22 // Should be OK to send channel3.port1 (should not have been disentangled by the previous failed calls).
23 channel.port1.postMessage("entangled ports", [channel3.port1, channel3.port2]); 23 channel.port1.postMessage("entangled ports", [channel3.port1, channel3.port2]);
24 24
25 shouldThrow('channel.port1.postMessage("notAnArray", channel3.port1)', '"TypeErr or: Failed to execute \'postMessage\' on \'MessagePort\': The 2nd argument is ne ither an array, nor does it have indexed properties."'); 25 shouldThrow('channel.port1.postMessage("notAnArray", channel3.port1)', '"TypeErr or: Failed to execute \'postMessage\' on \'MessagePort\': The 2nd argument is ne ither an array, nor does it have indexed properties."');
26 shouldThrow('channel.port1.postMessage("notASequence", [{length: 3}])', '"DataCl oneError: Failed to execute \'postMessage\' on \'MessagePort\': Value at index 0 does not have a transferable type."'); 26 shouldThrow('channel.port1.postMessage("notASequence", [{length: 3}])', '"TypeEr ror: Failed to execute \'postMessage\' on \'MessagePort\': Value at index 0 does not have a transferable type."');
27 var arrayBuffer = new ArrayBuffer(2); 27 var arrayBuffer = new ArrayBuffer(2);
28 shouldThrow('channel.port1.postMessage("duplicate buffer", [arrayBuffer, arrayBu ffer])', '"DataCloneError: Failed to execute \'postMessage\' on \'MessagePort\': ArrayBuffer at index 1 is a duplicate of an earlier ArrayBuffer."'); 28 shouldThrow('channel.port1.postMessage("duplicate buffer", [arrayBuffer, arrayBu ffer])', '"DataCloneError: Failed to execute \'postMessage\' on \'MessagePort\': ArrayBuffer at index 1 is a duplicate of an earlier ArrayBuffer."');
29 29
30 // Should not crash (we should figure out that the array contains undefined 30 // Should not crash (we should figure out that the array contains undefined
31 // entries). 31 // entries).
32 var largePortArray = []; 32 var largePortArray = [];
33 largePortArray[1234567890] = channel4.port1; 33 largePortArray[1234567890] = channel4.port1;
34 shouldThrow('channel.port1.postMessage("largeSequence", largePortArray)', '"Data CloneError: Failed to execute \'postMessage\' on \'MessagePort\': Value at index 0 is an untransferable \'undefined\' value."'); 34 shouldThrow('channel.port1.postMessage("largeSequence", largePortArray)', '"Type Error: Failed to execute \'postMessage\' on \'MessagePort\': Value at index 0 is an untransferable \'undefined\' value."');
35 35
36 channel.port1.postMessage("done"); 36 channel.port1.postMessage("done");
37 37
38 function testTransfers() { 38 function testTransfers() {
39 var channel0 = new MessageChannel(); 39 var channel0 = new MessageChannel();
40 40
41 var c1 = new MessageChannel(); 41 var c1 = new MessageChannel();
42 channel0.port1.postMessage({id:"send-port", port:c1.port1}, [c1.port1]); 42 channel0.port1.postMessage({id:"send-port", port:c1.port1}, [c1.port1]);
43 var c2 = new MessageChannel(); 43 var c2 = new MessageChannel();
44 channel0.port1.postMessage({id:"send-port-twice", port0:c2.port1, port1:c2.p ort1}, [c2.port1]); 44 channel0.port1.postMessage({id:"send-port-twice", port0:c2.port1, port1:c2.p ort1}, [c2.port1]);
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 } else if (event.data == "entangled ports") { 138 } else if (event.data == "entangled ports") {
139 if (event.ports.length == 2) 139 if (event.ports.length == 2)
140 testPassed("event.ports contains two ports when two ports re-sent af ter error"); 140 testPassed("event.ports contains two ports when two ports re-sent af ter error");
141 else 141 else
142 testFailed("event.ports contained " + event.ports.length + " when tw o ports re-sent after error"); 142 testFailed("event.ports contained " + event.ports.length + " when tw o ports re-sent after error");
143 } else if (event.data == "done") { 143 } else if (event.data == "done") {
144 testTransfers(); 144 testTransfers();
145 } else 145 } else
146 testFailed("Received unexpected message: " + event.data); 146 testFailed("Received unexpected message: " + event.data);
147 } 147 }
148
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698