Issue 1022283002: Throw TypeError if value conversion to transferable fails.

Issue 1022283002: Throw TypeError if value conversion to transferable fails. (Closed)

Created:
5 years, 9 months ago by sof

Modified:
5 years, 9 months ago

Reviewers:
haraken, Mike West, jsbell

CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Throw TypeError if value conversion to transferable fails. For postMessage(), when converting to a sequence<Transferable> value, throw a TypeError for any element that isn't an instance of a Transferable type. (Addresses http://w3c-test.org/webmessaging/with-ports/026.html failure.) R=haraken BUG=339441 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192320

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -29 lines)			Patch
M	LayoutTests/fast/dom/Window/window-postmessage-args.html	View	1 2	2 chunks	+14 lines, -9 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	LayoutTests/fast/events/message-port-clone.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/events/message-port-clone-expected.txt	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/events/message-port-multi-expected.txt	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/events/resources/message-port-multi.js	View	1 2	3 chunks	+4 lines, -5 lines	0 comments	Download
M	LayoutTests/fast/workers/worker-context-multi-port-expected.txt	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/workers/worker-multi-port-expected.txt	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/core/v8/SerializedScriptValue.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

sof

Please take a look. cf. https://lists.w3.org/Archives/Public/public-webapps/2015JanMar/0848.html

5 years, 9 months ago (2015-03-22 09:20:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022283002/40001

5 years, 9 months ago (2015-03-22 13:58:33 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-22 15:38:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192320