Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1022233002: [Smart Lock] Add UMA metrics to measure duration of unlock. (Closed)

Created:
5 years, 9 months ago by Ilya Sherman
Modified:
5 years, 8 months ago
Reviewers:
Tim Song
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Add UMA metrics to measure duration of unlock. BUG=461207 TEST=none R=tengs@chromium.org Committed: https://crrev.com/035213964677e1441afbec26c86af9774d98d014 Cr-Commit-Position: refs/heads/master@{#323166}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Hook into the existing PowerMonitor observer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M chrome/browser/signin/easy_unlock_metrics.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_metrics.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.h View 1 4 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 1 5 chunks +11 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Ilya Sherman
5 years, 9 months ago (2015-03-21 01:03:59 UTC) #1
Tim Song
There is already a similar metric for measuring the time to connect to the phone ...
5 years, 9 months ago (2015-03-25 18:17:28 UTC) #2
Ilya Sherman
On 2015/03/25 at 18:17:28, tengs wrote: > There is already a similar metric for measuring ...
5 years, 8 months ago (2015-04-01 00:16:13 UTC) #3
Tim Song
That is a good metric to have. LGTM.
5 years, 8 months ago (2015-04-01 00:17:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022233002/20001
5 years, 8 months ago (2015-04-01 00:25:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-01 01:48:01 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 01:49:02 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/035213964677e1441afbec26c86af9774d98d014
Cr-Commit-Position: refs/heads/master@{#323166}

Powered by Google App Engine
This is Rietveld 408576698