Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 10222005: Reapply https://chromiumcodereview.appspot.com/10204015. Fix (Closed)

Created:
8 years, 8 months ago by Oleg Eterevsky
Modified:
8 years, 8 months ago
Reviewers:
SeRya
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Reapply https://chromiumcodereview.appspot.com/10204015. Fix SelectFileDialogExtensionBrowserTest.SelectFileAndOpen -- file selection on opening the file manager. Do not auto-select the first file on entering a folder. BUG=chromium-os:26471 TEST=After entering the folder none of the files is selected. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133666 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134081

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -36 lines) Patch
M chrome/browser/resources/file_manager/js/directory_model.js View 1 2 9 chunks +16 lines, -33 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Oleg Eterevsky
8 years, 8 months ago (2012-04-25 14:43:54 UTC) #1
SeRya
8 years, 8 months ago (2012-04-26 07:08:09 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698