Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1022193002: Make the Sky pub package include our APK and teach sky_tool to install it (Closed)

Created:
5 years, 9 months ago by eseidel
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make the Sky pub package include our APK and teach sky_tool to install it I'm not sure this is the final long-term solution, but works for now. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bee69b02a993ec8c25b78d93804cb2f9a3e7a956

Patch Set 1 #

Patch Set 2 : Add missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -233 lines) Patch
D sky/sdk/packages/sky/bin/sky View 1 chunk +0 lines, -221 lines 0 comments Download
A + sky/sdk/packages/sky/lib/sky_tool View 1 2 chunks +15 lines, -6 lines 0 comments Download
M sky/tools/deploy_sdk.py View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 9 months ago (2015-03-20 21:34:27 UTC) #1
abarth-chromium
lgtm
5 years, 9 months ago (2015-03-20 21:34:37 UTC) #2
eseidel
5 years, 9 months ago (2015-03-20 21:35:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bee69b02a993ec8c25b78d93804cb2f9a3e7a956 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698