Issue 1022123004: Subzero: Fix lowering of the fabs() intrinsic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1022123004: Subzero: Fix lowering of the fabs() intrinsic. (Closed)

Created:
5 years, 9 months ago by Jim Stichnoth

Modified:
5 years, 9 months ago

Reviewers:
jvoung (off chromium), Karl, Mircea Trofin

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Fix lowering of the fabs() intrinsic. The pand instruction for masking off the sign bit can operate on a register or an m128 memory location, but not a 32-bit or 64-bit memory location. This means we need to make sure f32 and f64 operands are first loaded into a register. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5dfdf5fc48bfa42067ff3e470cb1a1207eb8fe31

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
	M	src/IceTargetLoweringX8632.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll	View		2 chunks	+10 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

5 years, 9 months ago (2015-03-20 19:56:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5dfdf5fc48bfa42067ff3e470cb1a1207eb8fe31 (tree was closed).