Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1022123002: Fix template angle bracket syntax leftovers (Closed)

Created:
5 years, 9 months ago by rwlbuis
Modified:
5 years, 9 months ago
Reviewers:
tkent, haraken, pdr., Mike West
CC:
aandrey+blink_chromium.org, Mads Ager (chromium), darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, Rik, caseq+blink_chromium.org, danakj, dcheng, devtools-reviews_chromium.org, Dominik Röttsches, dshwang, krit, dstockwell, Eric Willigers, eustas+blink_chromium.org, f(malita), jbroman, Justin Novosad, kouhei+heap_chromium.org, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, Mike Lawther (Google), mlamouri+watch-blink_chromium.org, oilpan-reviews, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, rjwright, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, shans, Steve Block, Timothy Loh, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix template angle bracket syntax leftovers In C++11 the parser is able to parse >> as the end of the template argument list. BUG=449681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192328

Patch Set 1 #

Patch Set 2 : Remove inspector change #

Patch Set 3 : Remove Body.cpp change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M Source/platform/animation/TimingFunctionTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/fonts/FontCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/GlyphMetricsMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/PictureSnapshot.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/PictureSnapshot.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 10 chunks +26 lines, -26 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 36 (17 generated)
rwlbuis
PTAL, these are the last bits!
5 years, 9 months ago (2015-03-20 15:50:03 UTC) #3
Mike West
LGTM. :)
5 years, 9 months ago (2015-03-20 16:29:30 UTC) #4
haraken
LGTM
5 years, 9 months ago (2015-03-21 00:10:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022123002/60001
5 years, 9 months ago (2015-03-21 00:25:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53460)
5 years, 9 months ago (2015-03-21 03:05:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022123002/60001
5 years, 9 months ago (2015-03-21 10:41:20 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53514)
5 years, 9 months ago (2015-03-21 12:23:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022123002/60001
5 years, 9 months ago (2015-03-21 12:48:55 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53533)
5 years, 9 months ago (2015-03-21 15:07:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022123002/60001
5 years, 9 months ago (2015-03-21 16:55:40 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53552)
5 years, 9 months ago (2015-03-21 18:27:29 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022123002/60001
5 years, 9 months ago (2015-03-22 02:24:48 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53585)
5 years, 9 months ago (2015-03-22 04:03:34 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022123002/60001
5 years, 9 months ago (2015-03-22 11:22:40 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53622)
5 years, 9 months ago (2015-03-22 13:06:53 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022123002/60001
5 years, 9 months ago (2015-03-22 20:39:17 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53696)
5 years, 9 months ago (2015-03-22 22:16:40 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022123002/60001
5 years, 9 months ago (2015-03-23 02:01:15 UTC) #35
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 03:04:26 UTC) #36
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192328

Powered by Google App Engine
This is Rietveld 408576698