Issue 1022083002: Only use 256x256 tiles on hd2000 nanobench bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1022083002: Only use 256x256 tiles on hd2000 nanobench bots (Closed)

Created:
5 years, 9 months ago by egdaniel

Modified:
5 years, 9 months ago

Reviewers:
mtklein, bsalomon, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@nanobenchTileSize

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Only use 256x256 tiles on hd2000 nanobench bots Initial experiments did show that the 256 tile size fixed the hd2000 win7 nanobot failures. However it did not have any effect on other bots, so this change is to move back to the larger tile size on all bots expect for the hd2000. BUG=skia: Committed: https://skia.googlesource.com/skia/+/9a0f629973ee97ea10f5e3c36a802eca4270d7e0

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -2 lines)			Patch
M	bench/SKPBench.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/nanobench_flags.json	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/nanobench_flags.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022083002/1

5 years, 9 months ago (2015-03-20 13:33:59 UTC) #6

commit-bot: I haz the power

5 years, 9 months ago (2015-03-20 14:03:56 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9a0f629973ee97ea10f5e3c36a802eca4270d7e0

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages