Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1022003003: Revert of add SkMatrix::decomposeScale (Closed)

Created:
5 years, 9 months ago by Corentin Wallez
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of add SkMatrix::decomposeScale (patchset #4 id:60001 of https://codereview.chromium.org/1006173005/) Reason for revert: Suspected to break GPU bots for test WebglConformance.conformance_canvas_drawingbuffer_static_canvas_test as it is the only relevant commit of the regression range http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28Intel%29/builds/9300 Original issue's description: > add SkMatrix::decomposeScale > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/adf9990cb56ca389f37f02ac637496083b3c3cfc TBR=senorblanco@google.com,robertphillips@google.com,jvanverth@google.com,senorblanco@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -79 lines) Patch
M include/core/SkMatrix.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 4 chunks +29 lines, -11 lines 0 comments Download
M src/core/SkMatrix.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/MatrixTest.cpp View 2 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Corentin Wallez
Created Revert of add SkMatrix::decomposeScale
5 years, 9 months ago (2015-03-20 15:08:28 UTC) #1
reed1
I reverted locally, and got the same failures w/ and w/o the revert. FAIL gl.drawingBufferWidth ...
5 years, 9 months ago (2015-03-20 15:26:07 UTC) #2
Corentin Wallez
On 2015/03/20 15:26:07, reed1 wrote: > I reverted locally, and got the same failures w/ ...
5 years, 9 months ago (2015-03-20 15:27:16 UTC) #3
egdaniel
On 2015/03/20 15:27:16, cwallez1 wrote: > On 2015/03/20 15:26:07, reed1 wrote: > > I reverted ...
5 years, 9 months ago (2015-03-20 15:42:41 UTC) #4
reed1
Here is the run with tip-of-tree chrome (no local changes) FAIL gl.drawingBufferWidth == 50 should ...
5 years, 9 months ago (2015-03-20 15:45:38 UTC) #5
Corentin Wallez
5 years, 9 months ago (2015-03-20 15:46:21 UTC) #6
Message was sent while issue was closed.
On 2015/03/20 15:45:38, reed1 wrote:
> Here is the run with tip-of-tree chrome (no local changes)
> 
> FAIL gl.drawingBufferWidth == 50 should be true. Was false.
> FAIL gl.drawingBufferHeight == 50 should be true. Was false.
> FAIL gl.getError() should be 0. Was 1285.
> FAIL at (25, 0) expected: 0,0,0,255 was 0,0,0,0
> FAIL at (25, 15) expected: 255,0,0,255 was 0,0,0,0
> FAIL at (0, 49) expected: 0,0,0,255 was 0,0,0,0
> 
> I conclude that reverting this skia change will not fix the test, so lets not
> revert it.
> 
> not lgtm

thanks for checking, I closed the issue.

Powered by Google App Engine
This is Rietveld 408576698