Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1021933003: Implementing ATK state mapping for Chrome UI. (Closed)

Created:
5 years, 9 months ago by shreeramk
Modified:
5 years, 9 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implementing ATK state mapping for Chrome UI. This CL includes implementation of ATK state mapping for chrome UI. Also, some roles has been added in this CL. BUG=463671 Committed: https://crrev.com/bf7014cb8f24b69f601206e114edccbdda2f2f5f Cr-Commit-Position: refs/heads/master@{#321734}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixing nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2 lines) Patch
M ui/accessibility/platform/ax_platform_node_auralinux.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_auralinux.cc View 1 5 chunks +53 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
shreeramk
PTAL. Thanks!
5 years, 9 months ago (2015-03-20 15:24:29 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/1021933003/diff/1/ui/accessibility/platform/ax_platform_node_auralinux.cc File ui/accessibility/platform/ax_platform_node_auralinux.cc (right): https://codereview.chromium.org/1021933003/diff/1/ui/accessibility/platform/ax_platform_node_auralinux.cc#newcode128 ui/accessibility/platform/ax_platform_node_auralinux.cc:128: static AtkStateSet* ax_platform_node_auralinux_ref_state_set(AtkObject* nit: wrap this differently so ...
5 years, 9 months ago (2015-03-20 15:32:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021933003/20001
5 years, 9 months ago (2015-03-23 03:30:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 04:30:13 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 04:30:36 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf7014cb8f24b69f601206e114edccbdda2f2f5f
Cr-Commit-Position: refs/heads/master@{#321734}

Powered by Google App Engine
This is Rietveld 408576698