Issue 102193006: fix drawVertices when we have both colors and textures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 102193006: fix drawVertices when we have both colors and textures (Closed)

Created:
6 years, 11 months ago by reed1

Modified:
6 years, 11 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

fix drawVertices when we have both colors and textures fix: don't re-call setContext on the composshader (i.e. on the tricolor shader) for each triangle, since the trishader handles that explicitly. Just call setContext on the original shader. BUG= Committed: https://code.google.com/p/skia/source/detail?r=12847

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/core/SkDraw.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

reed1

6 years, 11 months ago (2013-12-30 16:52:04 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r12847 (presubmit successful).

Expand Messages | Collapse Messages