sync/protocol/sync.proto - Issue 102193004: Checkpointing some Sync Attachment work. Added SyncAttachment and SyncAttachmentId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/protocol/sync.proto

Issue 102193004: Checkpointing some Sync Attachment work. Added SyncAttachment and SyncAttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added some DCHECKs and another test case. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/protocol/sync.proto

diff --git a/sync/protocol/sync.proto b/sync/protocol/sync.proto

index ecaceefbf6afb5d1956ea51455d24ee9b49edf94..e0e49b3bafd29723261599bebf04014ec42f1214 100644

--- a/sync/protocol/sync.proto

+++ b/sync/protocol/sync.proto

@@ -893,3 +893,11 @@ message ClientToServerResponse {

optional ChipBag new_bag_of_chips = 14;

};

+// Identifies an attachment.

+//

+// Note, message's definition is in flux and may change. Don't rely on it.

+message SyncAttachmentId {

Nicolas Zea 2013/12/30 19:10:31 Should we have this in its own proto file? This fi

maniscalco 2013/12/30 22:17:19 Good call. Done. I moved it to attachments.proto

+ // Uniquely identifies the attachment. Two attachments with the same unique_id

+ // are considered equivalent.

+ optional string unique_id = 1;

+};

« sync/api/sync_attachment_unittest.cc ('K') | « sync/api/sync_attachment_unittest.cc ('k') | sync/sync_api.gypi » ('j') | sync/sync_api.gypi » ('J')