Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: sync/protocol/proto_value_conversions_unittest.cc

Issue 102193004: Checkpointing some Sync Attachment work. Added SyncAttachment and SyncAttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added missing SYNC_EXPORT_PRIVATE modifier (was cause of link error on trybots). Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sync/protocol/proto_value_conversions.cc ('k') | sync/protocol/sync.proto » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Keep this file in sync with the .proto files in this directory. 5 // Keep this file in sync with the .proto files in this directory.
6 6
7 #include "sync/protocol/proto_value_conversions.h" 7 #include "sync/protocol/proto_value_conversions.h"
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 EXPECT_TRUE(ValueHasSpecifics(*(value_with_specifics.get()), 356 EXPECT_TRUE(ValueHasSpecifics(*(value_with_specifics.get()),
357 "get_updates.entries")); 357 "get_updates.entries"));
358 358
359 scoped_ptr<base::DictionaryValue> value_without_specifics( 359 scoped_ptr<base::DictionaryValue> value_without_specifics(
360 ClientToServerResponseToValue(message, false /* include_specifics */)); 360 ClientToServerResponseToValue(message, false /* include_specifics */));
361 EXPECT_FALSE(value_without_specifics->empty()); 361 EXPECT_FALSE(value_without_specifics->empty());
362 EXPECT_FALSE(ValueHasSpecifics(*(value_without_specifics.get()), 362 EXPECT_FALSE(ValueHasSpecifics(*(value_without_specifics.get()),
363 "get_updates.entries")); 363 "get_updates.entries"));
364 } 364 }
365 365
366 TEST_F(ProtoValueConversionsTest, SyncAttachmentIdToValue) {
367 TestSpecificsToValue(SyncAttachmentIdToValue);
368 }
369
366 } // namespace 370 } // namespace
367 } // namespace syncer 371 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/protocol/proto_value_conversions.cc ('k') | sync/protocol/sync.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698