Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1021923002: Add a "gn help all" option to GN to print all of the help at once. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn_help
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a "gn help all" option to GN to print all of the help at once. R=brettw@chromium.org BUG=468851 Committed: https://crrev.com/a87a30b7582cfe871801bbbfd156f6436e675e33 Cr-Commit-Position: refs/heads/master@{#325567}

Patch Set 1 #

Total comments: 6

Patch Set 2 : review feedback - remove braces and blank lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M tools/gn/command_help.cc View 1 3 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
5 years, 8 months ago (2015-04-15 03:10:54 UTC) #1
brettw
lgtm https://codereview.chromium.org/1021923002/diff/1/tools/gn/command_help.cc File tools/gn/command_help.cc (right): https://codereview.chromium.org/1021923002/diff/1/tools/gn/command_help.cc#newcode83 tools/gn/command_help.cc:83: for (const auto& s : switches::GetSwitches()) { No ...
5 years, 8 months ago (2015-04-16 23:35:13 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1021923002/diff/1/tools/gn/command_help.cc File tools/gn/command_help.cc (right): https://codereview.chromium.org/1021923002/diff/1/tools/gn/command_help.cc#newcode83 tools/gn/command_help.cc:83: for (const auto& s : switches::GetSwitches()) { On 2015/04/16 ...
5 years, 8 months ago (2015-04-16 23:36:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021923002/20001
5 years, 8 months ago (2015-04-16 23:41:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-17 00:31:31 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 00:32:26 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a87a30b7582cfe871801bbbfd156f6436e675e33
Cr-Commit-Position: refs/heads/master@{#325567}

Powered by Google App Engine
This is Rietveld 408576698