Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1021913004: views - fade out more cvc prompt elements during verification process (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Views - fade out more cvc prompt elements during wallet card verification process - animate in the "Verifying" overlay, in the end completely obscuring contents - don't hide the instructions message - footnote view is also faded out BUG=none Committed: https://crrev.com/c90b59db808926b62c1dcc42845af79fc5a82926 Cr-Commit-Position: refs/heads/master@{#322013}

Patch Set 1 #

Patch Set 2 : animate progress overlay #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -23 lines) Patch
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.h View 1 5 chunks +42 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 1 2 3 11 chunks +73 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
5 years, 9 months ago (2015-03-23 23:43:30 UTC) #2
sky
LGTM
5 years, 9 months ago (2015-03-24 13:25:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021913004/60001
5 years, 9 months ago (2015-03-24 15:28:20 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-24 16:41:55 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 16:42:45 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c90b59db808926b62c1dcc42845af79fc5a82926
Cr-Commit-Position: refs/heads/master@{#322013}

Powered by Google App Engine
This is Rietveld 408576698