Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 1021863005: Pass format as argument to getContentBitmapAsync. (Closed)

Created:
5 years, 9 months ago by sivag
Modified:
5 years, 8 months ago
Reviewers:
Ted C, AKV, Yaron, no sievers
CC:
chromium-reviews, darin-cc_chromium.org, jam, AKV
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass format as argument to getContentBitmapAsync. getScaledContentbitmap can process and give output in the requested format. getContentBitmapAsync should have this support. Especially on low-end devices we may need bitmaps with 16-bit formats. BUG=472457 Committed: https://crrev.com/7e95a121dc3382949ab1c854bcd4d95e7489d957 Cr-Commit-Position: refs/heads/master@{#323194}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Check for unsupported formats. #

Patch Set 3 : Add config parameter tp function header. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (4 generated)
sivag
ptal..
5 years, 9 months ago (2015-03-25 08:45:42 UTC) #2
Yaron
Why are you making this change? There's no BUG attached or any explanation provided https://codereview.chromium.org/1021863005/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java ...
5 years, 9 months ago (2015-03-25 14:13:57 UTC) #3
AKV
https://codereview.chromium.org/1021863005/diff/1/content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java File content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java (right): https://codereview.chromium.org/1021863005/diff/1/content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java#newcode118 content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java:118: Bitmap.Config.ARGB_8888, callback); Tests with Bitmap.Config.RGB_565 and other formats would ...
5 years, 9 months ago (2015-03-25 14:56:00 UTC) #5
sivag
On 2015/03/25 14:13:57, Yaron wrote: > Why are you making this change? There's no BUG ...
5 years, 9 months ago (2015-03-25 16:57:50 UTC) #6
Ted C
sievers@ would be a better reviewer than I.
5 years, 9 months ago (2015-03-26 20:33:34 UTC) #8
no sievers
Looks fine. You might want to add an early-out in ContentViewCoreImpl::GetScaledContentBitmap() for at least kUnknown_SkColorType. ...
5 years, 9 months ago (2015-03-26 20:46:36 UTC) #9
sivag
On 2015/03/26 20:46:36, sievers wrote: > Looks fine. You might want to add an early-out ...
5 years, 8 months ago (2015-03-30 17:12:45 UTC) #10
no sievers
Cab you also update the javadoc in ContentReadbackHandler.java (see Yaron's comment)?
5 years, 8 months ago (2015-03-30 17:20:13 UTC) #11
sivag
Added the config parameter in function header. ptal..
5 years, 8 months ago (2015-03-31 08:13:59 UTC) #12
no sievers
lgtm
5 years, 8 months ago (2015-03-31 18:41:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021863005/40001
5 years, 8 months ago (2015-04-01 05:58:29 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-01 06:42:26 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 06:43:18 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7e95a121dc3382949ab1c854bcd4d95e7489d957
Cr-Commit-Position: refs/heads/master@{#323194}

Powered by Google App Engine
This is Rietveld 408576698