Pass format as argument to getContentBitmapAsync.

Pass format as argument to getContentBitmapAsync.
getScaledContentbitmap can process and give output
in the requested format. getContentBitmapAsync should have
this support. Especially on low-end devices we may need
bitmaps with 16-bit formats.

BUG=472457
Committed: https://crrev.com/7e95a121dc3382949ab1c854bcd4d95e7489d957
Cr-Commit-Position: refs/heads/master@{#323194}

[sivag, 2015-03-25 08:44:39]

siva.gunturi@samsung.com changed reviewers:
+ tedchoc@chromium.org, yfriedman@chromium.org

[sivag, 2015-03-25 08:45:42]

ptal..

[Yaron, 2015-03-25 14:13:57]

Why are you making this change? There's no BUG attached or any explanation
provided

https://codereview.chromium.org/1021863005/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java
(right):

https://codereview.chromium.org/1021863005/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java:84:
Bitmap.Config config, GetBitmapCallback callback) {
You need to update the javadoc accordingly

[AKV, 2015-03-25 14:55:59]

ajith.v@chromium.org changed reviewers:
+ ajith.v@chromium.org

[AKV, 2015-03-25 14:56:00]

https://codereview.chromium.org/1021863005/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java
(right):

https://codereview.chromium.org/1021863005/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java:118:
Bitmap.Config.ARGB_8888, callback);
Tests with Bitmap.Config.RGB_565 and other formats would be ideal. Because we
are accepting general Config, so I feel we need to add tests for it to ensure we
get correct bitmap with all formats. Probably Yaron/Ted will have more to say
about it.

[sivag, 2015-03-25 16:57:50]

On 2015/03/25 14:13:57, Yaron wrote:
> Why are you making this change? There's no BUG attached or any explanation
> provided
> 
>
https://codereview.chromium.org/1021863005/diff/1/content/public/android/java...
> File
>
content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java
> (right):
> 
>
https://codereview.chromium.org/1021863005/diff/1/content/public/android/java...
>
content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java:84:
> Bitmap.Config config, GetBitmapCallback callback) {
> You need to update the javadoc accordingly

Hi Yaron I updated the description.
We should give the flexibility to user of getContentBitmapAsync api to
Choose the format as getScaledContentBitmap is designed. 
Please let me know your opinion.
I will update the javadoc.

[Ted C, 2015-03-26 20:33:33]

tedchoc@chromium.org changed reviewers:
+ sievers@chromium.org

[Ted C, 2015-03-26 20:33:34]

sievers@ would be a better reviewer than I.

[no sievers, 2015-03-26 20:46:36]

Looks fine. You might want to add an early-out in
ContentViewCoreImpl::GetScaledContentBitmap() for at least kUnknown_SkColorType.
Otherwise it would still do copy request and only fail later when it invokes
GLHelper.

[sivag, 2015-03-30 17:12:45]

On 2015/03/26 20:46:36, sievers wrote:
> Looks fine. You might want to add an early-out in
> ContentViewCoreImpl::GetScaledContentBitmap() for at least
kUnknown_SkColorType.
> Otherwise it would still do copy request and only fail later when it invokes
> GLHelper.

@Sievers,
I added the early-outcheck.ptal..

[no sievers, 2015-03-30 17:20:13]

Cab you also update the javadoc in ContentReadbackHandler.java (see Yaron's
comment)?

[sivag, 2015-03-31 08:13:59]

Added the config parameter in function header.
ptal..

[no sievers, 2015-03-31 18:41:24]

lgtm

[sivag, 2015-04-01 05:58:05]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2015-04-01 05:58:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1021863005/40001

[commit-bot: I haz the power, 2015-04-01 06:42:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-01 06:43:18]

Patchset 3 (id:??) landed as
https://crrev.com/7e95a121dc3382949ab1c854bcd4d95e7489d957
Cr-Commit-Position: refs/heads/master@{#323194}