Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1021863002: MIPS: [es6] implement Reflect.apply() & Reflect.construct() (Closed)

Created:
5 years, 9 months ago by akos.palfi.imgtec
Modified:
5 years, 9 months ago
Reviewers:
paul.l...
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [es6] implement Reflect.apply() & Reflect.construct() Port d21fd15467e16f185e511dbfbaeef7caddfe804a Known issue: the mjsunit/harmony/reflect-construct test fails, it will be addressed in a follow-up CL. BUG= Committed: https://crrev.com/05fcaa37cc7cd22636daa7ccc7eab1086a569662 Cr-Commit-Position: refs/heads/master@{#27326}

Patch Set 1 #

Patch Set 2 : Fixed indentation. #

Total comments: 2

Patch Set 3 : Fixes. #

Patch Set 4 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -116 lines) Patch
M src/mips/builtins-mips.cc View 1 2 4 chunks +164 lines, -58 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 3 4 chunks +164 lines, -58 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
paul.l...
LGTM, with one nit. https://codereview.chromium.org/1021863002/diff/20001/src/mips64/builtins-mips64.cc File src/mips64/builtins-mips64.cc (right): https://codereview.chromium.org/1021863002/diff/20001/src/mips64/builtins-mips64.cc#newcode1415 src/mips64/builtins-mips64.cc:1415: // On exit, the pushed ...
5 years, 9 months ago (2015-03-19 22:35:41 UTC) #2
akos.palfi.imgtec
https://codereview.chromium.org/1021863002/diff/20001/src/mips64/builtins-mips64.cc File src/mips64/builtins-mips64.cc (right): https://codereview.chromium.org/1021863002/diff/20001/src/mips64/builtins-mips64.cc#newcode1415 src/mips64/builtins-mips64.cc:1415: // On exit, the pushed arguments count is in ...
5 years, 9 months ago (2015-03-20 00:07:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021863002/60001
5 years, 9 months ago (2015-03-20 00:08:19 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-20 00:34:43 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 00:35:01 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/05fcaa37cc7cd22636daa7ccc7eab1086a569662
Cr-Commit-Position: refs/heads/master@{#27326}

Powered by Google App Engine
This is Rietveld 408576698