Add utils/android/SkAndroidSDKCanvas

Both DM and nanobench need this, so moving the duplicated code to
one common spot. (It's incomplete, and has had bugs, so it's not
like we can confidently write once, copy-paste, and not maintain
again.)

Because SkPathEffect::exposedInAndroidJavaAPI() only builds in the
Android Framework, we might want to make all this code Framework-only?

R=djsollen@google.com,mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/f7edcdedb64ee0d4a5c88807cd75ed1700e5bcce

[tomhudson, 2015-03-23 14:41:55]

PTAL

[djsollen, 2015-03-23 14:58:53]

yeah, make it framework only.

https://codereview.chromium.org/1021823003/diff/1/gyp/utils.gyp
File gyp/utils.gyp (right):

https://codereview.chromium.org/1021823003/diff/1/gyp/utils.gyp#newcode25
gyp/utils.gyp:25: '../include/utils/android',
I would prefer to have this in its own target.

utils.gyp:android_sdk_utils or something like that which can be conditionally
depended on by the 2 targets that need it.

https://codereview.chromium.org/1021823003/diff/1/include/utils/android/SkAnd...
File include/utils/android/SkAndroidSDKFilterCanvas.h (right):

https://codereview.chromium.org/1021823003/diff/1/include/utils/android/SkAnd...
include/utils/android/SkAndroidSDKFilterCanvas.h:27: class
SkAndroidSDKFilterCanvas : public SkCanvas {
I would drop filter and just call it SkAndroidSDKCanvas.

[tomhudson, 2015-03-23 15:56:15]

On 2015/03/23 14:58:53, djsollen wrote:
Done (assuming making it its own target is probably sufficient for
framework-only?)

+mtklein@ for gyp review

[tomhudson, 2015-03-23 15:56:31]

tomhudson@google.com changed reviewers:
+ mtklein@google.com

[tomhudson, 2015-03-23 15:56:47]

OK, this time for sure! (+mtklein@)

[mtklein, 2015-03-23 16:47:01]

https://codereview.chromium.org/1021823003/diff/20001/gyp/android_utils.gypi
File gyp/android_utils.gypi (right):

https://codereview.chromium.org/1021823003/diff/20001/gyp/android_utils.gypi#...
gyp/android_utils.gypi:10:
'<(skia_include_path)/utils/android/SkAndroidSDKCanvas.h',
Is this header really meant to be public?  Let's put this in src/utils/android
too.

https://codereview.chromium.org/1021823003/diff/20001/gyp/utils.gyp
File gyp/utils.gyp (right):

https://codereview.chromium.org/1021823003/diff/20001/gyp/utils.gyp#newcode136
gyp/utils.gyp:136: 'android_utils.gypi',
Unless you're planning on having these built into Chrome, I'd just drop the
.gypi and inline all this:

'sources': [
   '../include/utils/android/SkAndroidSDKCanvas.h',
   '../src/utils/android/SkAndroidSDKCanvas.cpp',
],

[tomhudson, 2015-03-23 17:30:35]

On 2015/03/23 16:47:01, mtklein wrote:

> ...

Done

[mtklein, 2015-03-23 17:49:02]

https://codereview.chromium.org/1021823003/diff/20001/gyp/utils.gyp
File gyp/utils.gyp (right):

https://codereview.chromium.org/1021823003/diff/20001/gyp/utils.gyp#newcode148
gyp/utils.gyp:148: '../include/utils/android',
Don't you want to keep this, switched over to '../src/utils/android'?  That way
if DM or nanobench depends on this, they get -Isrc/utils/android for free.

https://codereview.chromium.org/1021823003/diff/40001/gyp/utils.gyp
File gyp/utils.gyp (right):

https://codereview.chromium.org/1021823003/diff/40001/gyp/utils.gyp#newcode136
gyp/utils.gyp:136: '../include/core',
This ought to come from depending on core.gyp:*.

https://codereview.chromium.org/1021823003/diff/40001/gyp/utils.gyp#newcode137
gyp/utils.gyp:137: '../src/core',
Looks like you don't use anything from src/core?

https://codereview.chromium.org/1021823003/diff/40001/gyp/utils.gyp#newcode138
gyp/utils.gyp:138: '../src/utils/android',
Probably don't need this, given its the sources' directory.

[tomhudson, 2015-03-23 18:06:28]

https://codereview.chromium.org/1021823003/diff/20001/gyp/utils.gyp
File gyp/utils.gyp (right):

https://codereview.chromium.org/1021823003/diff/20001/gyp/utils.gyp#newcode148
gyp/utils.gyp:148: '../include/utils/android',
On 2015/03/23 17:49:02, mtklein wrote:
> Don't you want to keep this, switched over to '../src/utils/android'?  That
way
> if DM or nanobench depends on this, they get -Isrc/utils/android for free.

Done.

https://codereview.chromium.org/1021823003/diff/40001/gyp/utils.gyp
File gyp/utils.gyp (right):

https://codereview.chromium.org/1021823003/diff/40001/gyp/utils.gyp#newcode136
gyp/utils.gyp:136: '../include/core',
On 2015/03/23 17:49:02, mtklein wrote:
> This ought to come from depending on core.gyp:*.

Done.

https://codereview.chromium.org/1021823003/diff/40001/gyp/utils.gyp#newcode137
gyp/utils.gyp:137: '../src/core',
On 2015/03/23 17:49:02, mtklein wrote:
> Looks like you don't use anything from src/core?

Done.

https://codereview.chromium.org/1021823003/diff/40001/gyp/utils.gyp#newcode138
gyp/utils.gyp:138: '../src/utils/android',
On 2015/03/23 17:49:02, mtklein wrote:
> Probably don't need this, given its the sources' directory.

Done.

[djsollen, 2015-03-23 18:09:51]

lgtm

[tomhudson, 2015-03-23 18:11:56]

The CQ bit was checked by tomhudson@google.com

[commit-bot: I haz the power, 2015-03-23 18:12:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1021823003/60001

[commit-bot: I haz the power, 2015-03-23 18:15:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-23 18:15:59]

Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[tomhudson, 2015-03-23 19:07:42]

+Florin, Mike: example of an SkCanvas subclass replacing SkDrawFilter. Maybe
just replace my two macros with virtuals to genericize?

[tomhudson, 2015-03-23 19:45:55]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2015-03-23 19:45:55]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1021823003/#ps80001
(title: "Avoid some overinclusive gypping?")

[commit-bot: I haz the power, 2015-03-23 19:46:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1021823003/80001

[commit-bot: I haz the power, 2015-03-23 19:51:24]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/f7edcdedb64ee0d4a5c88807cd75ed1700e5bcce