[Thumbnails] Injecting TopSites into ThumbnailListSource.

[Thumbnails] Injecting TopSites into ThumbnailListSource.

Previously we store Profile and use it to retrieve TopSites. This caused
debug mode crash when we tried to retrieve TopSites from Profile from a
different thread. By storing TopSites directly this problem is averted.

BUG=468141
Committed: https://crrev.com/20ca225e329cfb9d97cf15475bee15ef5fd75fe5
Cr-Commit-Position: refs/heads/master@{#321488}

[huangs, 2015-03-19 18:28:34]

huangs@chromium.org changed reviewers:
+ beaudoin@chromium.org

[huangs, 2015-03-19 18:28:34]

PTAL.

[beaudoin, 2015-03-19 19:09:40]

The CQ bit was checked by beaudoin@chromium.org

[beaudoin, 2015-03-19 19:09:40]

lgtm

[commit-bot: I haz the power, 2015-03-19 19:10:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1021803002/1

[commit-bot: I haz the power, 2015-03-19 19:17:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-19 19:17:09]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[huangs, 2015-03-19 22:11:36]

huangs@chromium.org changed reviewers:
+ thestig@chromium.org

[huangs, 2015-03-19 22:11:36]

OWNER review to thestig@, PTAL.  Thanks!

[Lei Zhang, 2015-03-19 22:22:07]

lgtm

ThumbnailListSource's threading expectations is severely under-documented.
Please add some better documentation in the future if you own / use this class.

https://codereview.chromium.org/1021803002/diff/1/chrome/browser/thumbnails/t...
File chrome/browser/thumbnails/thumbnail_list_source.h (right):

https://codereview.chromium.org/1021803002/diff/1/chrome/browser/thumbnails/t...
chrome/browser/thumbnails/thumbnail_list_source.h:20: }  // namespace base
There's no need to comment when the namespace is this small.

[huangs, 2015-03-20 00:10:25]

Thanks. Added checks on IO thread and tested.  Committing.

https://codereview.chromium.org/1021803002/diff/1/chrome/browser/thumbnails/t...
File chrome/browser/thumbnails/thumbnail_list_source.h (right):

https://codereview.chromium.org/1021803002/diff/1/chrome/browser/thumbnails/t...
chrome/browser/thumbnails/thumbnail_list_source.h:20: }  // namespace base
On 2015/03/19 22:22:07, Lei Zhang wrote:
> There's no need to comment when the namespace is this small.

Done.

[huangs, 2015-03-20 00:10:31]

The CQ bit was checked by huangs@chromium.org

[huangs, 2015-03-20 00:10:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
beaudoin@chromium.org, thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1021803002/#ps20001
(title: "Ensured some routines are in the IO thread.")

[commit-bot: I haz the power, 2015-03-20 00:11:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1021803002/20001

[Lei Zhang, 2015-03-20 00:16:09]

lgtm++, thanks.

[commit-bot: I haz the power, 2015-03-20 01:32:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-20 01:33:43]

Patchset 2 (id:??) landed as
https://crrev.com/20ca225e329cfb9d97cf15475bee15ef5fd75fe5
Cr-Commit-Position: refs/heads/master@{#321488}