Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1021803002: [Thumbnails] Injecting TopSites into ThumbnailListSource. (Closed)

Created:
5 years, 9 months ago by huangs
Modified:
5 years, 9 months ago
Reviewers:
beaudoin, Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Thumbnails] Injecting TopSites into ThumbnailListSource. Previously we store Profile and use it to retrieve TopSites. This caused debug mode crash when we tried to retrieve TopSites from Profile from a different thread. By storing TopSites directly this problem is averted. BUG=468141 Committed: https://crrev.com/20ca225e329cfb9d97cf15475bee15ef5fd75fe5 Cr-Commit-Position: refs/heads/master@{#321488}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Ensured some routines are in the IO thread. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M chrome/browser/thumbnails/thumbnail_list_source.h View 1 4 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/thumbnails/thumbnail_list_source.cc View 1 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
huangs
PTAL.
5 years, 9 months ago (2015-03-19 18:28:34 UTC) #2
beaudoin
lgtm
5 years, 9 months ago (2015-03-19 19:09:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021803002/1
5 years, 9 months ago (2015-03-19 19:10:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/50829)
5 years, 9 months ago (2015-03-19 19:17:09 UTC) #7
huangs
OWNER review to thestig@, PTAL. Thanks!
5 years, 9 months ago (2015-03-19 22:11:36 UTC) #9
Lei Zhang
lgtm ThumbnailListSource's threading expectations is severely under-documented. Please add some better documentation in the future ...
5 years, 9 months ago (2015-03-19 22:22:07 UTC) #10
huangs
Thanks. Added checks on IO thread and tested. Committing. https://codereview.chromium.org/1021803002/diff/1/chrome/browser/thumbnails/thumbnail_list_source.h File chrome/browser/thumbnails/thumbnail_list_source.h (right): https://codereview.chromium.org/1021803002/diff/1/chrome/browser/thumbnails/thumbnail_list_source.h#newcode20 chrome/browser/thumbnails/thumbnail_list_source.h:20: ...
5 years, 9 months ago (2015-03-20 00:10:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021803002/20001
5 years, 9 months ago (2015-03-20 00:11:30 UTC) #14
Lei Zhang
lgtm++, thanks.
5 years, 9 months ago (2015-03-20 00:16:09 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 01:32:44 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 01:33:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20ca225e329cfb9d97cf15475bee15ef5fd75fe5
Cr-Commit-Position: refs/heads/master@{#321488}

Powered by Google App Engine
This is Rietveld 408576698