Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2600)

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 1021763003: Add install warning for printerProvider permission (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_set_unittest.cc
diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc
index 43c609a924352320fa03a4cb9420c54b5efdbd70..2be3dda827d221d6128164affd4cfc551342dddf 100644
--- a/chrome/common/extensions/permissions/permission_set_unittest.cc
+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc
@@ -663,7 +663,6 @@ TEST(PermissionsTest, PermissionMessages) {
skip.insert(APIPermission::kOverrideEscFullscreen);
skip.insert(APIPermission::kPointerLock);
skip.insert(APIPermission::kPower);
- skip.insert(APIPermission::kPrinterProvider);
skip.insert(APIPermission::kSessions);
skip.insert(APIPermission::kStorage);
skip.insert(APIPermission::kSystemCpu);
@@ -1738,4 +1737,17 @@ TEST(PermissionsTest, IsPrivilegeIncrease_DeclarativeWebRequest) {
extension->GetType()));
}
+TEST(PermissionsTest, PrinterProviderPermission) {
+ scoped_refptr<Extension> extension =
+ LoadManifest("permissions", "printer_provider.json");
+ APIPermissionSet apis;
+ apis.insert(APIPermission::kPrinterProvider);
+ EXPECT_TRUE(extension->is_platform_app());
+ EXPECT_TRUE(extension->permissions_data()->HasAPIPermission(
+ APIPermission::kPrinterProvider));
+ EXPECT_TRUE(VerifyOnePermissionMessage(
+ extension->permissions_data(),
+ "Add printing destinations and access any jobs you submit to them"));
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698