Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1021763003: Add install warning for printerProvider permission (Closed)

Created:
5 years, 9 months ago by tbarzic
Modified:
5 years, 9 months ago
Reviewers:
Yoyo Zhou, Ilya Sherman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add install warning for printerProvider permission BUG=None TEST=Install an extension with printerProvider permission; install dialog should contain a warning for the permission Committed: https://crrev.com/4298949c51c3c35e795a221f61a6427fd93d427f Cr-Commit-Position: refs/heads/master@{#322553}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : unittest #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M chrome/common/extensions/docs/templates/articles/permission_warnings.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_rules.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 2 chunks +13 lines, -1 line 0 comments Download
A chrome/test/data/extensions/permissions/printer_provider.json View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/common/permissions/extensions_api_permissions.cc View 1 chunk +5 lines, -1 line 0 comments Download
M extensions/common/permissions/permission_message.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/extensions_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
tbarzic
Please take a look. isherman owner for histograms
5 years, 9 months ago (2015-03-26 18:36:08 UTC) #2
Yoyo Zhou
Can you add a unit test for this?
5 years, 9 months ago (2015-03-26 19:48:16 UTC) #3
tbarzic
added a unit test
5 years, 9 months ago (2015-03-26 20:09:44 UTC) #4
Yoyo Zhou
LGTM
5 years, 9 months ago (2015-03-26 20:22:41 UTC) #5
Ilya Sherman
histograms.xml lgtm
5 years, 9 months ago (2015-03-26 20:23:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021763003/60001
5 years, 9 months ago (2015-03-27 04:28:21 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-27 11:17:49 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 11:18:58 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4298949c51c3c35e795a221f61a6427fd93d427f
Cr-Commit-Position: refs/heads/master@{#322553}

Powered by Google App Engine
This is Rietveld 408576698