Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1021763002: Add ANGLE perf tests targets. (Closed)

Created:
5 years, 9 months ago by Jamie Madill
Modified:
5 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ANGLE perf tests targets. This will enable building the ANGLE perf tests on Windows perf bot builders. BUG=angleproject:744 BUG=468852 R=sievers@chromium.org, thakis@chromium.org Committed: https://crrev.com/027aa70482334c1ff20e86f7dec7bdb046a31dcc Cr-Commit-Position: refs/heads/master@{#322078}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Add missing main file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + gpu/angle_perftests_main.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Jamie Madill
sievers, PTAL at the changes in gpu/. Nico, PTAL at the changes to all.gyp. cc'ing ...
5 years, 9 months ago (2015-03-23 21:02:31 UTC) #4
Nico
build lgtm, but please don't land this until https://chromium-review.googlesource.com/#/c/261965/ has made its way into chromium
5 years, 9 months ago (2015-03-23 21:23:12 UTC) #5
Ken Russell (switch to Gerrit)
Looks good from my standpoint.
5 years, 9 months ago (2015-03-23 21:37:31 UTC) #7
no sievers
lgtm
5 years, 9 months ago (2015-03-23 22:47:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021763002/40001
5 years, 9 months ago (2015-03-24 20:12:35 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-24 22:01:37 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 22:02:47 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/027aa70482334c1ff20e86f7dec7bdb046a31dcc
Cr-Commit-Position: refs/heads/master@{#322078}

Powered by Google App Engine
This is Rietveld 408576698