Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 1021723006: X87: [es6] implement Reflect.apply() & Reflect.construct() (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] implement Reflect.apply() & Reflect.construct() port d21fd15467e16f185e511dbfbaeef7caddfe804a (r27316) original commit message: [es6] implement Reflect.apply() & Reflect.construct() BUG= Committed: https://crrev.com/a21cc19eefb4b8c54d37a5d60fd5799bd56d4926 Cr-Commit-Position: refs/heads/master@{#27460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -71 lines) Patch
M src/x87/builtins-x87.cc View 3 chunks +195 lines, -71 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 9 months ago (2015-03-24 10:15:52 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-03-26 01:35:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021723006/1
5 years, 9 months ago (2015-03-26 01:35:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 02:24:28 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 02:24:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a21cc19eefb4b8c54d37a5d60fd5799bd56d4926
Cr-Commit-Position: refs/heads/master@{#27460}

Powered by Google App Engine
This is Rietveld 408576698