media/base/android/media_source_player.cc - Issue 1021723003: Android: Never automatically enter fullscreen when media playback starts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_source_player.cc

Issue 1021723003: Android: Never automatically enter fullscreen when media playback starts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/android/browser_media_player_manager.h ('K') | « media/base/android/media_player_manager.h ('k') | media/base/android/media_source_player_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_source_player.cc

diff --git a/media/base/android/media_source_player.cc b/media/base/android/media_source_player.cc

index 85ffd545d87877f787ca8d3a13fc55c1408460bd..b7a68445086c5c8014df7a03534b963a3cc3622e 100644

--- a/media/base/android/media_source_player.cc

+++ b/media/base/android/media_source_player.cc

@@ -121,15 +121,6 @@ void MediaSourcePlayer::Start() {

playing_ = true;

- bool request_fullscreen = IsProtectedSurfaceRequired();

xhwang 2015/03/20 18:07:44 MediaSourcePlayer::IsProtectedSurfaceRequired() is

ddorwin 2015/03/20 18:45:25 Done. Thanks.

-#if defined(VIDEO_HOLE)

- // Skip to request fullscreen when hole-punching is used.

- request_fullscreen = request_fullscreen &&

- !manager()->ShouldUseVideoOverlayForEmbeddedEncryptedVideo();

-#endif // defined(VIDEO_HOLE)

- if (request_fullscreen)

- manager()->RequestFullScreen(player_id());

StartInternal();

}