src/compiler/verifier.cc - Issue 1021713005: [turbofan]: Integrate basic type feedback for property accesses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/verifier.cc

Issue 1021713005: [turbofan]: Integrate basic type feedback for property accesses. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/verifier.cc

diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc

index 86b7521198fda1ebd27dc9451f4c8742cca65039..0768ece2a3915da3b43574cb20e05dcb96a099a0 100644

--- a/src/compiler/verifier.cc

+++ b/src/compiler/verifier.cc

@@ -618,10 +618,6 @@ void Verifier::Visitor::Check(Node* node) {

case IrOpcode::kReferenceEqual: {

// (Unique, Any) -> Boolean and

// (Any, Unique) -> Boolean

- if (typing == TYPED) {

- CHECK(bounds(ValueInput(node, 0)).upper->Is(Type::Unique()) ||

- bounds(ValueInput(node, 1)).upper->Is(Type::Unique()));

- }

CheckUpperIs(node, Type::Boolean());

break;

}

« no previous file with comments | « src/compiler/pipeline.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »