Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: src/compiler/verifier.cc

Issue 1021713005: [turbofan]: Integrate basic type feedback for property accesses. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 601 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 break; 612 break;
613 case IrOpcode::kStringAdd: 613 case IrOpcode::kStringAdd:
614 // (String, String) -> String 614 // (String, String) -> String
615 CheckValueInputIs(node, 0, Type::String()); 615 CheckValueInputIs(node, 0, Type::String());
616 CheckValueInputIs(node, 1, Type::String()); 616 CheckValueInputIs(node, 1, Type::String());
617 CheckUpperIs(node, Type::String()); 617 CheckUpperIs(node, Type::String());
618 break; 618 break;
619 case IrOpcode::kReferenceEqual: { 619 case IrOpcode::kReferenceEqual: {
620 // (Unique, Any) -> Boolean and 620 // (Unique, Any) -> Boolean and
621 // (Any, Unique) -> Boolean 621 // (Any, Unique) -> Boolean
622 /* TODO(titzer)
titzer 2015/03/24 10:49:32 Haha, no one noticed this!
Michael Starzinger 2015/03/24 12:11:18 Maeh, verifier, shmerifier. :)
622 if (typing == TYPED) { 623 if (typing == TYPED) {
623 CHECK(bounds(ValueInput(node, 0)).upper->Is(Type::Unique()) || 624 CHECK(bounds(ValueInput(node, 0)).upper->Is(Type::Unique()) ||
624 bounds(ValueInput(node, 1)).upper->Is(Type::Unique())); 625 bounds(ValueInput(node, 1)).upper->Is(Type::Unique()));
625 } 626 }*/
626 CheckUpperIs(node, Type::Boolean()); 627 CheckUpperIs(node, Type::Boolean());
627 break; 628 break;
628 } 629 }
629 case IrOpcode::kObjectIsSmi: 630 case IrOpcode::kObjectIsSmi:
630 CheckValueInputIs(node, 0, Type::Any()); 631 CheckValueInputIs(node, 0, Type::Any());
631 CheckUpperIs(node, Type::Boolean()); 632 CheckUpperIs(node, Type::Boolean());
632 break; 633 break;
633 case IrOpcode::kObjectIsNonNegativeSmi: 634 case IrOpcode::kObjectIsNonNegativeSmi:
634 CheckValueInputIs(node, 0, Type::Any()); 635 CheckValueInputIs(node, 0, Type::Any());
635 CheckUpperIs(node, Type::Boolean()); 636 CheckUpperIs(node, Type::Boolean());
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
1076 // Check inputs for all nodes in the block. 1077 // Check inputs for all nodes in the block.
1077 for (size_t i = 0; i < block->NodeCount(); i++) { 1078 for (size_t i = 0; i < block->NodeCount(); i++) {
1078 Node* node = block->NodeAt(i); 1079 Node* node = block->NodeAt(i);
1079 CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1); 1080 CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1);
1080 } 1081 }
1081 } 1082 }
1082 } 1083 }
1083 } 1084 }
1084 } 1085 }
1085 } // namespace v8::internal::compiler 1086 } // namespace v8::internal::compiler
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698