Source/bindings/modules/v8/V8BindingForModulesTest.cpp - Issue 1021713003: [bindings] Let NativeValueTraits<T>::nativeValue be variadic function and merge various convers…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/v8/V8BindingForModulesTest.cpp

Issue 1021713003: [bindings] Let NativeValueTraits<T>::nativeValue be variadic function and merge various convers… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: IDB related changes alone. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/modules/v8/V8BindingForModulesTest.cpp

diff --git a/Source/bindings/modules/v8/V8BindingForModulesTest.cpp b/Source/bindings/modules/v8/V8BindingForModulesTest.cpp

index ec155aa609e75a73d5094df265229abc67edb5bb..b45ea6ef12efc0dafc81e4b70ce5bc964f44f9fb 100644

--- a/Source/bindings/modules/v8/V8BindingForModulesTest.cpp

+++ b/Source/bindings/modules/v8/V8BindingForModulesTest.cpp

@@ -43,7 +43,8 @@ IDBKey* checkKeyFromValueAndKeyPathInternal(v8::Isolate* isolate, const ScriptVa

IDBKeyPath idbKeyPath(keyPath);

EXPECT_TRUE(idbKeyPath.isValid());

- return createIDBKeyFromScriptValueAndKeyPath(isolate, value, idbKeyPath);

+ NonThrowableExceptionState exceptionState;

+ return ScriptValue::to<IDBKey*>(isolate, value, exceptionState, idbKeyPath);

}

void checkKeyPathNullValue(v8::Isolate* isolate, const ScriptValue& value, const String& keyPath)

« no previous file with comments | « Source/bindings/modules/v8/V8BindingForModules.cpp ('k') | Source/modules/indexeddb/IDBCursor.cpp » ('j') | no next file with comments »