Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: Source/bindings/modules/v8/V8BindingForModulesTest.cpp

Issue 1021713003: [bindings] Let NativeValueTraits<T>::nativeValue be variadic function and merge various convers… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed the compiler error behind ASSERT flag Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/modules/v8/V8BindingForModulesTest.cpp
diff --git a/Source/bindings/modules/v8/V8BindingForModulesTest.cpp b/Source/bindings/modules/v8/V8BindingForModulesTest.cpp
index cece895d69b0846b9d6ebc9f00983afaba76964e..578a326e71ff8c9a6f15bda47d78d22412010453 100644
--- a/Source/bindings/modules/v8/V8BindingForModulesTest.cpp
+++ b/Source/bindings/modules/v8/V8BindingForModulesTest.cpp
@@ -42,8 +42,8 @@ IDBKey* checkKeyFromValueAndKeyPathInternal(v8::Isolate* isolate, const ScriptVa
{
IDBKeyPath idbKeyPath(keyPath);
EXPECT_TRUE(idbKeyPath.isValid());
-
- return createIDBKeyFromScriptValueAndKeyPath(isolate, value, idbKeyPath);
+ NonThrowableExceptionState exceptionState;
bashi 2015/03/19 23:53:41 Can we pass exceptionState from the caller of this
+ return ScriptValue::to<IDBKey*>(isolate, value, exceptionState, idbKeyPath);
}
void checkKeyPathNullValue(v8::Isolate* isolate, const ScriptValue& value, const String& keyPath)

Powered by Google App Engine
This is Rietveld 408576698