Retrieve and pass subpixel lcd geometry on windows

ui/gfx/font_render_params_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "ui/gfx/font_render_params.h"
-
+#include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/singleton.h"
+#include "base/win/registry.h"
+#include "ui/gfx/font_render_params.h"
 #include "ui/gfx/win/direct_write.h"
 #include "ui/gfx/win/singleton_hwnd.h"
 
 namespace gfx {
 
 namespace {
 
+FontRenderParams::SubpixelRendering GetSubpixelRenderingGeometry() {
+  DISPLAY_DEVICE display_device = {sizeof(DISPLAY_DEVICE), 0};
+  for (int i = 0; EnumDisplayDevices(nullptr, i, &display_device, 0); ++i) {
+    // TODO(scottmg): We only support the primary device currently.
+    if (display_device.StateFlags & DISPLAY_DEVICE_PRIMARY_DEVICE) {
+      base::FilePath trimmed =
+          base::FilePath(display_device.DeviceName).BaseName();
+      base::win::RegKey key(
+          HKEY_LOCAL_MACHINE,
+          (L"SOFTWARE\\Microsoft\\Avalon.Graphics\\" + trimmed.value()).c_str(),

[msw, 2015/03/26 20:41:25]

Hmm, I wonder why I don't have "Avalon.Graphics" in
"HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\" locally with Win7+Aero with ClearType
enabled... It's described at
https://msdn.microsoft.com/en-us/library/aa970267%28v=vs.110%29.aspx so it
should be legitimate, but I wonder if there's a newer/older/alternate key to
check. I worry about disabling subpixel rendering without this key; it seems
safer to assume RGB (as before) unless the key exists and specifies BGR.

[scottmg, 2015/03/26 21:16:17]

Oh, good catch. I just confirmed on a clean Win7 VM that the key doesn't show up
until the cleartype tuner has been run. Switched to RGB default.

+          KEY_READ);
+      DWORD pixel_structure;
+      if (key.ReadValueDW(L"PixelStructure", &pixel_structure) ==
+          ERROR_SUCCESS) {
+        if (pixel_structure == 1)
+          return FontRenderParams::SUBPIXEL_RENDERING_RGB;
+        else if (pixel_structure == 2)

[msw, 2015/03/26 20:41:25]

nit: no else after return.

[scottmg, 2015/03/26 21:16:17]

Done.

+          return FontRenderParams::SUBPIXEL_RENDERING_BGR;
+      }

[msw, 2015/03/26 20:41:25]

nit: can you break the loop of enumerating devices at the end of this block,
since we only handle the primary device for now?

[scottmg, 2015/03/26 21:16:17]

Done.

+    }
+  }
+
+  // ClearType is not enabled, or retrieval failed.

[msw, 2015/03/26 20:41:25]

nit: I have ClearType on but don't have this key... revise comment?

[scottmg, 2015/03/26 21:16:17]

Done.

+  return FontRenderParams::SUBPIXEL_RENDERING_NONE;
+}
+
 // Caches font render params and updates them on system notifications.
 class CachedFontRenderParams : public gfx::SingletonHwnd::Observer {
  public:
   static CachedFontRenderParams* GetInstance() {
     return Singleton<CachedFontRenderParams>::get();
   }
 
   const FontRenderParams& GetParams() {
     if (params_)
       return *params_;
 
     params_.reset(new FontRenderParams());
     params_->antialiasing = false;
     params_->subpixel_positioning = false;
     params_->autohinter = false;
     params_->use_bitmaps = false;
     params_->hinting = FontRenderParams::HINTING_MEDIUM;
     params_->subpixel_rendering = FontRenderParams::SUBPIXEL_RENDERING_NONE;
 
     BOOL enabled = false;
     if (SystemParametersInfo(SPI_GETFONTSMOOTHING, 0, &enabled, 0) && enabled) {
       params_->antialiasing = true;
       // GDI does not support subpixel positioning.
       params_->subpixel_positioning = win::IsDirectWriteEnabled();
 
       UINT type = 0;
       if (SystemParametersInfo(SPI_GETFONTSMOOTHINGTYPE, 0, &type, 0) &&
           type == FE_FONTSMOOTHINGCLEARTYPE) {
-        params_->subpixel_rendering = FontRenderParams::SUBPIXEL_RENDERING_RGB;
+        params_->subpixel_rendering = GetSubpixelRenderingGeometry();
       }
     }
     gfx::SingletonHwnd::GetInstance()->AddObserver(this);
     return *params_;
   }
 
  private:
   friend struct DefaultSingletonTraits<CachedFontRenderParams>;
 
   CachedFontRenderParams() {}
@@ skipping 21 matching lines @@
 
 FontRenderParams GetFontRenderParams(const FontRenderParamsQuery& query,
                                      std::string* family_out) {
   if (family_out)
     NOTIMPLEMENTED();
   // Customized font rendering settings are not supported, only defaults.
   return CachedFontRenderParams::GetInstance()->GetParams();
 }
 
 }  // namespace gfx