Chromium Code Reviews Chromium Code Reviews
Issue 1021643002:
Retrieve and pass subpixel lcd geometry on windows (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "ui/gfx/font_render_params.h" | 5 #include "ui/gfx/font_render_params.h" |
| 6 | 6 |
| 7 #include "base/logging.h" | |
| 8 | |
| 7 namespace gfx { | 9 namespace gfx { |
| 8 | 10 |
| 9 FontRenderParams::FontRenderParams() | 11 FontRenderParams::FontRenderParams() |
| 10 : antialiasing(true), | 12 : antialiasing(true), |
| 11 subpixel_positioning(true), | 13 subpixel_positioning(true), |
| 12 autohinter(false), | 14 autohinter(false), |
| 13 use_bitmaps(false), | 15 use_bitmaps(false), |
| 14 hinting(HINTING_MEDIUM), | 16 hinting(HINTING_MEDIUM), |
| 15 subpixel_rendering(SUBPIXEL_RENDERING_NONE) { | 17 subpixel_rendering(SUBPIXEL_RENDERING_NONE) { |
| 16 } | 18 } |
| 17 | 19 |
| 18 FontRenderParams::~FontRenderParams() {} | 20 FontRenderParams::~FontRenderParams() {} |
| 19 | 21 |
| 22 // static | |
| 23 SkFontHost::LCDOrder FontRenderParams::SubpixelRenderingToSkiaLCDOrder( | |
| 24 FontRenderParams::SubpixelRendering subpixel_rendering) { | |
| 25 switch (subpixel_rendering) { | |
| 26 case gfx::FontRenderParams::SUBPIXEL_RENDERING_NONE: | |
| 27 case gfx::FontRenderParams::SUBPIXEL_RENDERING_RGB: | |
| 28 case gfx::FontRenderParams::SUBPIXEL_RENDERING_VRGB: | |
| 29 return SkFontHost::kRGB_LCDOrder; | |
| 30 case gfx::FontRenderParams::SUBPIXEL_RENDERING_BGR: | |
| 31 case gfx::FontRenderParams::SUBPIXEL_RENDERING_VBGR: | |
| 32 return SkFontHost::kBGR_LCDOrder; | |
| 33 default: | |
|
msw
2015/03/26 20:41:25
nit: omit default case to get compile errors inste
scottmg
2015/03/26 21:16:16
I can never figure out which compiler wants what.
msw
2015/03/26 21:56:02
Yeah, I prefer the newer version, but you can go e
| |
| 34 NOTREACHED(); | |
| 35 return SkFontHost::kRGB_LCDOrder; | |
| 36 } | |
| 37 } | |
| 38 | |
| 39 // static | |
| 40 SkFontHost::LCDOrientation | |
| 41 FontRenderParams::SubpixelRenderingToSkiaLCDOrientation( | |
| 42 FontRenderParams::SubpixelRendering subpixel_rendering) { | |
| 43 switch (subpixel_rendering) { | |
| 44 case gfx::FontRenderParams::SUBPIXEL_RENDERING_NONE: | |
| 45 case gfx::FontRenderParams::SUBPIXEL_RENDERING_RGB: | |
| 46 case gfx::FontRenderParams::SUBPIXEL_RENDERING_BGR: | |
| 47 return SkFontHost::kHorizontal_LCDOrientation; | |
| 48 case gfx::FontRenderParams::SUBPIXEL_RENDERING_VRGB: | |
| 49 case gfx::FontRenderParams::SUBPIXEL_RENDERING_VBGR: | |
| 50 return SkFontHost::kVertical_LCDOrientation; | |
| 51 default: | |
|
msw
2015/03/26 20:41:25
nit: omit default case to get compile errors inste
scottmg
2015/03/26 21:16:16
As above.
| |
| 52 NOTREACHED(); | |
| 53 return SkFontHost::kHorizontal_LCDOrientation; | |
| 54 } | |
| 55 } | |
| 56 | |
| 20 FontRenderParamsQuery::FontRenderParamsQuery(bool for_web_contents) | 57 FontRenderParamsQuery::FontRenderParamsQuery(bool for_web_contents) |
| 21 : for_web_contents(for_web_contents), | 58 : for_web_contents(for_web_contents), |
| 22 pixel_size(0), | 59 pixel_size(0), |
| 23 point_size(0), | 60 point_size(0), |
| 24 style(-1), | 61 style(-1), |
| 25 device_scale_factor(0) { | 62 device_scale_factor(0) { |
| 26 } | 63 } |
| 27 | 64 |
| 28 FontRenderParamsQuery::~FontRenderParamsQuery() {} | 65 FontRenderParamsQuery::~FontRenderParamsQuery() {} |
| 29 | 66 |
| 30 } // namespace gfx | 67 } // namespace gfx |
| OLD | NEW |
