Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1021613002: Fail gracefully if the active profile can't be found in the ProfileInfoCache (Closed)

Created:
5 years, 9 months ago by noms (inactive)
Modified:
5 years, 9 months ago
Reviewers:
noms, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fail gracefully if the active profile can't be found in the ProfileInfoCache The underlying reason for not finding the profile is probably crbug.com/464616, but this should still not crash. BUG=421215 Committed: https://crrev.com/3c62345e860267d5f190f66dcb3994d97f111a28 Cr-Commit-Position: refs/heads/master@{#321353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
noms (inactive)
If for whatever reason the profile isn't in the ProfileInfoCache (like that trailing slashes bug), ...
5 years, 9 months ago (2015-03-18 21:34:01 UTC) #2
sky
LGTM
5 years, 9 months ago (2015-03-18 23:03:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021613002/1
5 years, 9 months ago (2015-03-19 00:11:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-19 04:12:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021613002/1
5 years, 9 months ago (2015-03-19 14:05:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 14:27:43 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 14:28:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c62345e860267d5f190f66dcb3994d97f111a28
Cr-Commit-Position: refs/heads/master@{#321353}

Powered by Google App Engine
This is Rietveld 408576698