Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1021533002: [ARM64] [turbofan] Support uxtb/uxth for add/sub. (Closed)

Created:
5 years, 9 months ago by jbramley
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev, m.m.capewell
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM64] [turbofan] Support uxtb/uxth for add/sub. Add support for appending extend modes uxtb or uxth to add and subtract instructions, and using them in the instruction selector. BUG= Committed: https://crrev.com/3fdfe613f8e099854453c994f073b64d8ad97bc2 Cr-Commit-Position: refs/heads/master@{#27303}

Patch Set 1 #

Patch Set 2 : Small fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -11 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +9 lines, -7 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 chunks +33 lines, -4 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 2 chunks +82 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jbramley
5 years, 9 months ago (2015-03-18 15:21:29 UTC) #2
jbramley
On 2015/03/18 15:21:29, jbramley wrote: Oops, sorry. I'll look into the test failures.
5 years, 9 months ago (2015-03-18 15:51:04 UTC) #3
jbramley
On 2015/03/18 15:51:04, jbramley wrote: > On 2015/03/18 15:21:29, jbramley wrote: > > Oops, sorry. ...
5 years, 9 months ago (2015-03-18 16:52:38 UTC) #4
Benedikt Meurer
Nice. LGTM
5 years, 9 months ago (2015-03-19 05:00:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021533002/20001
5 years, 9 months ago (2015-03-19 10:15:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 12:44:13 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 12:44:29 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3fdfe613f8e099854453c994f073b64d8ad97bc2
Cr-Commit-Position: refs/heads/master@{#27303}

Powered by Google App Engine
This is Rietveld 408576698