Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 102153002: Put all of SkPostConfig.h inside top level ifdef. (Closed)

Created:
7 years ago by bungeman-skia
Modified:
7 years ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Put all of SkPostConfig.h inside top level ifdef. Due to inconsistent indentation, the last third of this header is outside of the top level ifdef header guard. This CL fixes that, as well as makes the indents more consistent to avoid this issue in the future. R=mtklein@google.com, reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=12482

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -257 lines) Patch
M include/core/SkPostConfig.h View 1 5 chunks +220 lines, -257 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bungeman-skia
Let's fight over the style choices. https://codereview.chromium.org/102153002/diff/1/include/core/SkPostConfig.h File include/core/SkPostConfig.h (left): https://codereview.chromium.org/102153002/diff/1/include/core/SkPostConfig.h#oldcode241 include/core/SkPostConfig.h:241: #if 0 This ...
7 years ago (2013-12-03 15:38:31 UTC) #1
mtklein
lgtm with small tweaks (No surprise, seems I wrote SK_ALWAYS_INLINE in this style myself!) https://codereview.chromium.org/102153002/diff/1/include/core/SkPostConfig.h ...
7 years ago (2013-12-03 16:55:17 UTC) #2
bungeman-skia
https://codereview.chromium.org/102153002/diff/1/include/core/SkPostConfig.h File include/core/SkPostConfig.h (right): https://codereview.chromium.org/102153002/diff/1/include/core/SkPostConfig.h#newcode174 include/core/SkPostConfig.h:174: # define SK_DEBUGBREAK(cond) do { if (!(cond)) { SkNO_RETURN_HINT(); ...
7 years ago (2013-12-03 17:07:59 UTC) #3
reed1
lgtm
7 years ago (2013-12-04 16:33:05 UTC) #4
bungeman-chromium
7 years ago (2013-12-04 16:40:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r12482.

Powered by Google App Engine
This is Rietveld 408576698