Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1021523002: Check for GC interrupt in JSON parser. (Closed)

Created:
5 years, 9 months ago by ulan
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Check for GC interrupt in JSON parser. BUG=v8:3974 LOG=NO Committed: https://crrev.com/16ff37db4a416523e54c473640ccf52b53c6655e Cr-Commit-Position: refs/heads/master@{#27334}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/execution.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/execution.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/json-parser.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ulan
PTAL. Below is the test that fails with OOM without this CL. I am not ...
5 years, 9 months ago (2015-03-18 16:39:11 UTC) #2
ulan
5 years, 9 months ago (2015-03-18 16:40:10 UTC) #4
Yang
On 2015/03/18 16:40:10, ulan wrote: lgtm. Please add a comment in the json parser on ...
5 years, 9 months ago (2015-03-20 09:15:33 UTC) #5
ulan
On 2015/03/20 09:15:33, Yang wrote: > On 2015/03/18 16:40:10, ulan wrote: > > lgtm. Please ...
5 years, 9 months ago (2015-03-20 09:29:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021523002/40001
5 years, 9 months ago (2015-03-20 09:29:52 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-20 09:52:22 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 09:52:43 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/16ff37db4a416523e54c473640ccf52b53c6655e
Cr-Commit-Position: refs/heads/master@{#27334}

Powered by Google App Engine
This is Rietveld 408576698