Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1021513002: Build 64-bit binaries by default when compiling for iOS (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build 64-bit binaries by default when compiling for iOS All the bots force the value of target_subarch so the default value is only used by developpers. Since the vast majority of the devices used on a daily basis by developpers are 64-bit devices swap the default to 64-bit. BUG=None Committed: https://crrev.com/4ef3ab4e104014a35ac36903368b0111c52a1389 Cr-Commit-Position: refs/heads/master@{#323039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M build/common.gypi View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
sdefresne
Let's see if this breaks anything!
5 years, 9 months ago (2015-03-18 14:57:29 UTC) #2
justincohen
LGTM, but confirm with rohitrao/stuargmorgan
5 years, 9 months ago (2015-03-18 14:58:17 UTC) #3
sdefresne
rohitrao: justin and I both think it would make sense to default to arm64? compilation ...
5 years, 9 months ago (2015-03-18 15:04:00 UTC) #5
rohitrao (ping after 24h)
What percentage of our users are on 64bit these days?
5 years, 9 months ago (2015-03-18 15:05:07 UTC) #6
rohitrao (ping after 24h)
lgtm
5 years, 9 months ago (2015-03-18 16:18:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021513002/1
5 years, 8 months ago (2015-03-31 13:40:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/52952)
5 years, 8 months ago (2015-03-31 13:49:47 UTC) #11
sdefresne
jochen: OWNERS for build/common.gypi
5 years, 8 months ago (2015-03-31 14:04:00 UTC) #13
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-03-31 14:05:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021513002/1
5 years, 8 months ago (2015-03-31 14:30:44 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 15:34:55 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 15:35:49 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ef3ab4e104014a35ac36903368b0111c52a1389
Cr-Commit-Position: refs/heads/master@{#323039}

Powered by Google App Engine
This is Rietveld 408576698