Create gfx::Screen at startup for cast_shell

chromecast/browser/cast_browser_main_parts.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/cast_browser_main_parts.h"
 
 #include <signal.h>
 #include <sys/prctl.h>
 
 #include "base/command_line.h"
@@ skipping 22 matching lines @@
 #include "content/public/common/content_switches.h"
 #include "media/base/browser_cdm_factory.h"
 #include "media/base/media_switches.h"
 
 #if defined(OS_ANDROID)
 #include "chromecast/crash/android/crash_handler.h"
 #include "components/crash/browser/crash_dump_manager_android.h"
 #include "net/android/network_change_notifier_factory_android.h"
 #endif
 
+#if defined(USE_AURA)
+#include "ui/aura/test/test_screen.h"
+#include "ui/gfx/screen.h"
+#endif
+
 namespace {
 
 #if !defined(OS_ANDROID)
 int kSignalsToRunClosure[] = { SIGTERM, SIGINT, };
 
 // Closure to run on SIGTERM and SIGINT.
 base::Closure* g_signal_closure = NULL;
 
 void RunClosureOnSignal(int signum) {
   LOG(ERROR) << "Got signal " << signum;
@@ skipping 134 matching lines @@
     LOG(ERROR) << "Could not find crash dump location.";
   }
   cast_browser_process_->SetCrashDumpManager(
       make_scoped_ptr(new breakpad::CrashDumpManager(crash_dumps_dir)));
 #else
   base::FilePath home_dir;
   CHECK(PathService::Get(DIR_CAST_HOME, &home_dir));
   if (!base::CreateDirectory(home_dir))
     return 1;
 #endif
+
+#if defined(USE_AURA)
+  // Screen can (and should) exist even with no displays connected. Its presence
+  // is assumed as an interface to access display information, e.g. from metrics
+  // code.  See CastContentWindow::CreateWindowTree for update when resolution
+  // is available.
+  DCHECK(!gfx::Screen::GetScreenByType(gfx::SCREEN_TYPE_NATIVE));
+  gfx::Screen::SetScreenInstance(gfx::SCREEN_TYPE_NATIVE,
+                                 aura::TestScreen::Create(gfx::Size(0, 0)));

[oshima, 2015/03/25 22:39:55]

Hmm, production code should not depend on test code, but looks like this is
already used in cast. lgtm for now, but could you please create cast's screen
and remove the dependency to test?

[halliwell, 2015/03/26 00:28:24]

Yes, sure.  I filed https://code.google.com/p/chromium/issues/detail?id=470735
to follow up on this.

And to clarify - should we just create our own Screen implementation?  We have a
TODO in CastContentWindow::CreateWindowTree that suggests "use ozone's screen
implementation when it is ready" ... does that still apply?

+#endif
   return 0;
 }
 
 void CastBrowserMainParts::PreMainMessageLoopRun() {
   scoped_refptr<PrefRegistrySimple> pref_registry(new PrefRegistrySimple());
   metrics::RegisterPrefs(pref_registry.get());
   cast_browser_process_->SetPrefService(
       PrefServiceHelper::CreatePrefService(pref_registry.get()));
 
 #if !defined(OS_ANDROID)
@@ skipping 70 matching lines @@
   NOTREACHED();
 #else
   cast_browser_process_->cast_service()->Finalize();
   cast_browser_process_->metrics_service_client()->Finalize();
   cast_browser_process_.reset();
 #endif
 }
 
 }  // namespace shell
 }  // namespace chromecast