Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 102143003: IDL compiler: [ImplementedAs] for [InitializedByEventConstructor] (Closed)

Created:
7 years ago by Nils Barth (inactive)
Modified:
7 years ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: [ImplementedAs] for [InitializedByEventConstructor] One use: core/events/KeyboardEvent.idl [ImplementedAs=location, DeprecateAs=KeyboardEventKeyLocation, InitializedByEventConstructor] readonly attribute unsigned long keyLocation; BUG=239771 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163498

Patch Set 1 #

Patch Set 2 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -8 lines) Patch
M Source/bindings/scripts/unstable/v8_attributes.py View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/TestInterfaceEventConstructor.idl View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 4 chunks +42 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
7 years ago (2013-12-10 05:18:36 UTC) #1
haraken
LGTM
7 years ago (2013-12-10 05:19:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/102143003/20001
7 years ago (2013-12-10 05:20:02 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-10 05:20:21 UTC) #4
Message was sent while issue was closed.
Change committed as 163498

Powered by Google App Engine
This is Rietveld 408576698