Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1021393002: Re-enable ChannelMojo (Closed)

Created:
5 years, 9 months ago by Hajime Morrita
Modified:
5 years, 8 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable ChannelMojo It was disabled due to crbug.com/466814 that is now fixed. It's time to turn it on again. R=viettrungluu@chromium.org BUG=466814, 377980 Committed: https://crrev.com/c99c93842fa50f85888d069f0be962462f92a643 Cr-Commit-Position: refs/heads/master@{#322092} Committed: https://crrev.com/ce41e7007dea7b653a7ee848419b47e582f165d2 Cr-Commit-Position: refs/heads/master@{#322886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (2 generated)
Hajime Morrita
5 years, 9 months ago (2015-03-20 21:06:43 UTC) #1
Hajime Morrita
This depends on https://codereview.chromium.org/1023043002/
5 years, 9 months ago (2015-03-20 21:07:16 UTC) #2
Hajime Morrita
On 2015/03/20 21:07:16, morrita wrote: > This depends on https://codereview.chromium.org/1023043002/ Trung: Rubberstamp please?
5 years, 9 months ago (2015-03-24 21:21:04 UTC) #3
viettrungluu
lgtm
5 years, 9 months ago (2015-03-24 22:06:29 UTC) #4
Hajime Morrita
Thanks!
5 years, 9 months ago (2015-03-24 22:24:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021393002/1
5 years, 9 months ago (2015-03-24 22:26:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 23:46:54 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c99c93842fa50f85888d069f0be962462f92a643 Cr-Commit-Position: refs/heads/master@{#322092}
5 years, 9 months ago (2015-03-24 23:47:33 UTC) #9
tkent
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1029263008/ by tkent@chromium.org. ...
5 years, 9 months ago (2015-03-25 04:39:17 UTC) #10
Hajime Morrita
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1034753002/ by morrita@chromium.org. ...
5 years, 9 months ago (2015-03-25 17:17:34 UTC) #11
Hajime Morrita
Relanding as https://codereview.chromium.org/1040163002/ is in.
5 years, 8 months ago (2015-03-30 20:26:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021393002/1
5 years, 8 months ago (2015-03-30 20:26:56 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 21:53:48 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 21:54:26 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce41e7007dea7b653a7ee848419b47e582f165d2
Cr-Commit-Position: refs/heads/master@{#322886}

Powered by Google App Engine
This is Rietveld 408576698